From: Carsten Otte <cotte@de.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, schwidefsky@de.ibm.com, akpm@osdl.org
Subject: [RFC/PATCH 5/5] madvice/fadvice: execute in place (V2)
Date: Wed, 18 May 2005 15:54:05 +0200 [thread overview]
Message-ID: <1116424446.2202.20.camel@cotte.boeblingen.de.ibm.com> (raw)
In-Reply-To: <1116422644.2202.1.camel@cotte.boeblingen.de.ibm.com>
[RFC/PATCH 5/5] madvice/fadvice: execute in place (V2)
This patch makes sys_madvice and sys_fadvice return 0 on advices to
cache data assoctiated with files that do have get_xip_page. Since the
data for those is in memory anyway, we can just ignore the advice...
This patch is unchanged from previous version.
Signed-off-by: Carsten Otte <cotte@de.ibm.com>
---
diff -ruN linux-git/mm/fadvise.c linux-git-xip/mm/fadvise.c
--- linux-git/mm/fadvise.c 2005-05-17 14:23:36.000000000 +0200
+++ linux-git-xip/mm/fadvise.c 2005-05-17 20:16:40.000000000 +0200
@@ -43,6 +43,10 @@
goto out;
}
+ if (mapping->a_ops->get_xip_page)
+ /* no bad return value, but ignore advice */
+ goto out;
+
/* Careful about overflows. Len == 0 means "as much as possible" */
endbyte = offset + len;
if (!len || endbyte < len)
diff -ruN linux-git/mm/madvise.c linux-git-xip/mm/madvise.c
--- linux-git/mm/madvise.c 2005-05-17 14:23:36.000000000 +0200
+++ linux-git-xip/mm/madvise.c 2005-05-17 20:16:40.000000000 +0200
@@ -65,6 +65,10 @@
if (!file)
return -EBADF;
+ if (file->f_mapping->a_ops->get_xip_page)
+ /* no bad return value, but ignore advice */
+ return 0;
+
start = ((start - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
if (end > vma->vm_end)
end = vma->vm_end;
prev parent reply other threads:[~2005-05-18 13:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1116422644.2202.1.camel@cotte.boeblingen.de.ibm.com>
2005-05-18 13:53 ` [RFC/PATCH 1/5] bdev: execute in place (V2) Carsten Otte
2005-05-18 14:27 ` Christoph Hellwig
2005-05-18 15:36 ` Carsten Otte
2005-05-18 15:37 ` Christoph Hellwig
2005-05-18 13:53 ` [RFC/PATCH 2/5] mm/fs: " Carsten Otte
2005-05-18 14:27 ` Christoph Hellwig
2005-05-18 14:56 ` Carsten Otte
2005-05-18 15:00 ` Christoph Hellwig
2005-05-18 15:31 ` Carsten Otte
2005-05-18 15:36 ` Christoph Hellwig
2005-05-18 15:50 ` Carsten Otte
2005-05-18 15:53 ` Christoph Hellwig
2005-05-18 13:53 ` [RFC/PATCH 3/5] ext2: " Carsten Otte
2005-05-18 13:53 ` [RFC/PATCH 4/5] loop: " Carsten Otte
2005-05-18 14:28 ` Christoph Hellwig
2005-05-18 14:38 ` Carsten Otte
2005-05-18 13:54 ` Carsten Otte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1116424446.2202.20.camel@cotte.boeblingen.de.ibm.com \
--to=cotte@de.ibm.com \
--cc=akpm@osdl.org \
--cc=cotte@freenet.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).