From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Revell Subject: Re: [RFC] [PATCH] OCFS2 Date: Thu, 19 May 2005 11:20:08 -0400 Message-ID: <1116516008.21685.25.camel@mindpipe> References: <20050518223303.GE1340@ca-server1.us.oracle.com> <200505190230.23624.phillips@istop.com> <428C69EA.6080001@pobox.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Daniel Phillips , Mark Fasheh , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com, torvalds@osdl.org, akpm@osdl.org, wim.coekaerts@oracle.com, lmb@suse.de Return-path: Received: from viper.oldcity.dca.net ([216.158.38.4]:32684 "HELO viper.oldcity.dca.net") by vger.kernel.org with SMTP id S262552AbVESPUK (ORCPT ); Thu, 19 May 2005 11:20:10 -0400 To: Jeff Garzik In-Reply-To: <428C69EA.6080001@pobox.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 2005-05-19 at 06:26 -0400, Jeff Garzik wrote: > Daniel Phillips wrote: > > Zero terminated strings for lock names is bad taste. It generates a bunch of > > useless strlen executions and you force an ascii namespace for no apparent > > reason. Add a 9th parameter, namelen, to the lock call maybe? > > What's wrong with ascii strings? > > We call those 'UTF8' these days. I think you just answered your own question. Lee