From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Pekka Enberg <penberg@gmail.com>,
linux-kernel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net,
viro@parcelfarce.linux.theplanet.co.uk,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][patch 4/7] v9fs: VFS superblock operations (2.0-rc6)
Date: Wed, 25 May 2005 07:54:03 +0300 [thread overview]
Message-ID: <1116996843.9580.8.camel@localhost> (raw)
In-Reply-To: <a4e6962a0505241208214a200f@mail.gmail.com>
Hi,
On Tue, 2005-05-24 at 14:08 -0500, Eric Van Hensbergen wrote:
> Thanks for the comments! A bit of a clarification on slab policy - I
> did my own find_slab() so I could keep tight control over my own slabs
> (and monitor for slab leaks, etc.). There seems to be similar
> functionality for the malloc slabs (kmem_find_general_cachep), but I'm
> not sure if this is really something that is generally useful. What
> do folks think? Is this something that would be generally useful to
> add to slab.c? Or is there something like this that I just
> overlooked?
Most subsystems also implement this (a custom allocator for tracking
memory leaks) so, yes, I think it's generally useful. However, adding
yet another custom allocator is not the way to go. Perhaps some of the
fs developers could cue in here to talk about how they track memory
leaks? Pretty please?
In the meantime, please drop the custom allocator from your code.
Pekka
next prev parent reply other threads:[~2005-05-25 4:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-23 22:25 [RFC][patch 4/7] v9fs: VFS superblock operations (2.0-rc6) ericvh
2005-05-24 7:11 ` Pekka Enberg
2005-05-24 19:08 ` Eric Van Hensbergen
2005-05-25 4:54 ` Pekka Enberg [this message]
2005-05-25 11:55 ` Eric Van Hensbergen
2005-05-25 12:15 ` Pekka J Enberg
2005-05-25 14:41 ` Eric Van Hensbergen
2005-05-25 5:17 ` [RFC][patch 4/7] " Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1116996843.9580.8.camel@localhost \
--to=penberg@cs.helsinki.fi \
--cc=ericvh@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@gmail.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).