linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Badari Pulavarty <pbadari@us.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] pass iocb to dio_iodone_t
Date: 10 Jun 2005 08:37:49 -0700	[thread overview]
Message-ID: <1118417869.4301.325.camel@dyn9047017072.beaverton.ibm.com> (raw)
In-Reply-To: <20050610154858.GA2766@lst.de>

On Fri, 2005-06-10 at 08:48, Christoph Hellwig wrote:
> On Fri, Jun 10, 2005 at 08:25:01AM -0700, Badari Pulavarty wrote:
> > Just curious on why XFS needs end_io callback ?
> 
> To convert unwritten extents to written extents.
> 
> > And also, why is dio->inode != iocb->ki_filp->f_dentry->d_inode
> > for XFS ?
> 
> It's not.

Hmm.. Then, I don't understand your patch. Is there a follow up
patch to make use of iocb in linvfs_unwritten_convert_direct() ?

All you did was, to pass "iocb" instead of "inode". Then got
inode from "iocb". (which you claimed they are same).

Am I miss understanding something ?

Thanks,
Badari




  reply	other threads:[~2005-06-10 16:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-10 15:00 [PATCH] pass iocb to dio_iodone_t Christoph Hellwig
2005-06-10 15:25 ` Badari Pulavarty
2005-06-10 15:48   ` Christoph Hellwig
2005-06-10 15:37     ` Badari Pulavarty [this message]
2005-06-10 16:03       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1118417869.4301.325.camel@dyn9047017072.beaverton.ibm.com \
    --to=pbadari@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).