From mboxrd@z Thu Jan 1 00:00:00 1970 From: Badari Pulavarty Subject: Re: [PATCH] pass iocb to dio_iodone_t Date: 10 Jun 2005 08:37:49 -0700 Message-ID: <1118417869.4301.325.camel@dyn9047017072.beaverton.ibm.com> References: <20050610150052.GA1632@lst.de> <1118417101.4301.315.camel@dyn9047017072.beaverton.ibm.com> <20050610154858.GA2766@lst.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Andrew Morton , linux-fsdevel Return-path: Received: from e34.co.us.ibm.com ([32.97.110.132]:25318 "EHLO e34.co.us.ibm.com") by vger.kernel.org with ESMTP id S262588AbVFJQAZ (ORCPT ); Fri, 10 Jun 2005 12:00:25 -0400 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e34.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j5AG0M2h105360 for ; Fri, 10 Jun 2005 12:00:23 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j5AG0KQl205142 for ; Fri, 10 Jun 2005 10:00:20 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j5AG0Jfk032386 for ; Fri, 10 Jun 2005 10:00:19 -0600 To: Christoph Hellwig In-Reply-To: <20050610154858.GA2766@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 2005-06-10 at 08:48, Christoph Hellwig wrote: > On Fri, Jun 10, 2005 at 08:25:01AM -0700, Badari Pulavarty wrote: > > Just curious on why XFS needs end_io callback ? > > To convert unwritten extents to written extents. > > > And also, why is dio->inode != iocb->ki_filp->f_dentry->d_inode > > for XFS ? > > It's not. Hmm.. Then, I don't understand your patch. Is there a follow up patch to make use of iocb in linvfs_unwritten_convert_direct() ? All you did was, to pass "iocb" instead of "inode". Then got inode from "iocb". (which you claimed they are same). Am I miss understanding something ? Thanks, Badari