From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: dnotify/inotify and vfs questions Date: Thu, 25 Aug 2005 13:40:18 +0100 Message-ID: <1124973618.17190.9.camel@icampbell-debian> References: <20050823130023.GB8305@diku.dk> <20050823152331.GA10486@mail.shareable.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs-client@lists.samba.org, Asser =?ISO-8859-1?Q?Fem=F8?= Return-path: Received: from mta09-winn.ispmail.ntl.com ([81.103.221.49]:52733 "EHLO mta09-winn.ispmail.ntl.com") by vger.kernel.org with ESMTP id S964963AbVHYMkf (ORCPT ); Thu, 25 Aug 2005 08:40:35 -0400 To: Jamie Lokier In-Reply-To: <20050823152331.GA10486@mail.shareable.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 2005-08-23 at 16:23 +0100, Jamie Lokier wrote: > ... > if (any_dnotify_or_inotify_events_pending) { > read_dnotify_or_inotify_events(); > if (any_events_related_to(file)) { > store_in_userspace_stat_cache(file, stat(file)); > } > } > stat_info = lookup_userspace_stat_cache(file); > > Now that's a silly way to save one system call in the fast path by itself. I'm not that familiar with inotify internals but doesn't read_dnotify_or_inotify_events() or any_dnotify_or_inotify_events_pending() involve a syscall? Ian. -- Ian Campbell Current Noise: Primordial - The Coffin Ships Today is the first day of the rest of the mess.