From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mingming Cao Subject: Re: kjournald() with DIO Date: Wed, 14 Sep 2005 10:23:03 -0700 Message-ID: <1126718583.4010.6.camel@localhost.localdomain> References: <1126567387.14837.36.camel@dyn9047017102.beaverton.ibm.com> <20050912163732.036b2971.akpm@osdl.org> <1126569984.14837.47.camel@dyn9047017102.beaverton.ibm.com> <20050912172935.19907edf.akpm@osdl.org> <1126630370.14837.60.camel@dyn9047017102.beaverton.ibm.com> <20050913160701.355cd46a.akpm@osdl.org> Reply-To: cmm@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Badari Pulavarty , linux-fsdevel@vger.kernel.org, sct@redhat.com Return-path: Received: from e31.co.us.ibm.com ([32.97.110.129]:62204 "EHLO e31.co.us.ibm.com") by vger.kernel.org with ESMTP id S1030292AbVINRYe (ORCPT ); Wed, 14 Sep 2005 13:24:34 -0400 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e31.co.us.ibm.com (8.12.10/8.12.9) with ESMTP id j8EHOVC6053606 for ; Wed, 14 Sep 2005 13:24:33 -0400 Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id j8EHNC0D389630 for ; Wed, 14 Sep 2005 11:23:12 -0600 Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) by d03av01.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j8EHNAKH001800 for ; Wed, 14 Sep 2005 11:23:10 -0600 To: Andrew Morton In-Reply-To: <20050913160701.355cd46a.akpm@osdl.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 2005-09-13 at 16:07 -0700, Andrew Morton wrote: > Or simply ignore the invalidate_inode_pages2_range() return value in > generic_file_direct_IO(). > Could we simply do that? I found some discussions about why we check the return value of invalidate_inode_pages2_range() in generic_file_direct_IO(): http://marc.theaimsgroup.com/?l=linux-kernel&m=109850054025709&w=2 It seems the check for EIO was added to 2.6.11 to handle the case of parallel direct IO and mapped IO. It is possible that the mapped IO dirty the pages after the a_ops->direct_IO. In that case, an error will return back to the caller of DIO to indicate the race. Thanks, Mingming