From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mingming Cao Subject: Re: kjournald() with DIO Date: Wed, 21 Sep 2005 11:22:14 -0700 Message-ID: <1127326934.3925.12.camel@localhost.localdomain> References: <1126567387.14837.36.camel@dyn9047017102.beaverton.ibm.com> <20050912163732.036b2971.akpm@osdl.org> <1126569984.14837.47.camel@dyn9047017102.beaverton.ibm.com> <20050912172935.19907edf.akpm@osdl.org> <1126878128.4486.13.camel@sisko.sctweedie.blueyonder.co.uk> Reply-To: cmm@us.ibm.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Andrew Morton , Badari Pulavarty , linux-fsdevel@vger.kernel.org, Mingming Cao Return-path: Received: from e36.co.us.ibm.com ([32.97.110.154]:26816 "EHLO e36.co.us.ibm.com") by vger.kernel.org with ESMTP id S1751353AbVIUSWW (ORCPT ); Wed, 21 Sep 2005 14:22:22 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e36.co.us.ibm.com (8.12.11/8.12.11) with ESMTP id j8LILHVY008592 for ; Wed, 21 Sep 2005 14:21:17 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id j8LIMn2N540576 for ; Wed, 21 Sep 2005 12:22:49 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id j8LIMGOg025117 for ; Wed, 21 Sep 2005 12:22:17 -0600 To: "Stephen C. Tweedie" In-Reply-To: <1126878128.4486.13.camel@sisko.sctweedie.blueyonder.co.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 2005-09-16 at 14:42 +0100, Stephen C. Tweedie wrote: > Hi, > > On Tue, 2005-09-13 at 01:29, Andrew Morton wrote: > > > Have you spoken with Mingming about this? She's chasing a similar race. > > She's currently working on getting the ext3-debug patch working so we can > > find out how those buffers (which apparently aren't even attached to the > > journal) came to have an elevated refcount. > > Here's the latest version of ext3 buffer tracing which I've been using. > It's basically just the same as one from Andrew from about 2.6.5 > vintage, with a few changes in places to deal with new bits of code that > need temporary buffer_heads initialised properly for tracing. > > It has survived a couple of hours of fsx and fsstress in parallel, but I > haven't run any O_DIRECT tests with it on the current git kernel, so > there may stil be problems in that area. Your patch works smoothly running iozone DIO tests overnight. It also successfully shows the last 32 activities history of the busy buffer which caused the EIO failure here, and the results matches what the previous analysis. A minor improvement, to translate BJ_Locked state into a proper string. Signed-off-by: Mingming Cao cmm@us.ibm.com --- linux-2.6.5-7.191-cmm/fs/jbd-kernel.c | 1 + 1 files changed, 1 insertion(+) diff -puN fs/jbd-kernel.c~buffer-trace-fix fs/jbd-kernel.c --- linux-2.6.5-7.191/fs/jbd-kernel.c~buffer-trace-fix 2005-09-19 15:48:03.000000000 -0700 +++ linux-2.6.5-7.191-cmm/fs/jbd-kernel.c 2005-09-19 15:50:16.000000000 -0700 @@ -163,6 +163,7 @@ static const char *b_jlist_to_string(uns case BJ_Shadow: return "BJ_Shadow"; case BJ_LogCtl: return "BJ_LogCtl"; case BJ_Reserved: return "BJ_Reserved"; + case BJ_Locked: return "BJ_Locked"; #endif default: return "Bad b_jlist"; } _