From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [RFC] possible badness in prune_dcache() Date: Mon, 07 Apr 2008 11:49:03 +0100 Message-ID: <11281.1207565343@redhat.com> References: <1207322926.12346.30.camel@bear.shadowland> <1207309200.12346.25.camel@bear.shadowland> Cc: dhowells@redhat.com, Miklos Szeredi , linux-fsdevel@vger.kernel.org, Andrew.Perepechko@Sun.COM To: Alex Lyashkov Return-path: Received: from mx1.redhat.com ([66.187.233.31]:46093 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751220AbYDGKtK (ORCPT ); Mon, 7 Apr 2008 06:49:10 -0400 In-Reply-To: <1207322926.12346.30.camel@bear.shadowland> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Alex Lyashkov wrote: > Thanks for answer, > > Yes this commit - fix issue with umount, but not resolve main question: > why prune_dcache kill dentry with diffrent super block? this produce > long loop with skip loop instead of early exit and move dentry from > select_parent again to end of list. > > > On Fri, 2008-04-04 at 14:42 +0200, Miklos Szeredi wrote: > > > When investigation livelock in RHEL3, i found possible badness in > > > prune_dcache, which exist in 2.6.24 also. > > > > Have you actually tested with 2.6.24? shrink_dcache_parent() isn't > > called from umount anymore. I think this is the commit responsible > > for fixing the issue: Am I missing part of the first part of this conversation? David