public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: dhowells@redhat.com, Jeff Layton <jlayton@kernel.org>,
	Christian Brauner <brauner@kernel.org>,
	netfs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	lvc-project@linuxtesting.org,
	syzbot+404b4b745080b6210c6c@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] netfs: fix kernel BUG in iov_iter_revert()
Date: Wed, 04 Dec 2024 14:03:03 +0000	[thread overview]
Message-ID: <1128190.1733320983@warthog.procyon.org.uk> (raw)
In-Reply-To: <20241202093943.227786-1-dmantipov@yandex.ru>

Hi Dmitry,

> So wrap 'netfs_prepare_read_iterator()' to handle all possible
> -ENOMEM cases and mark the corresponding subrequest as cancelled.

I think there's a slightly better way to do it.  There are three users of
netfs_prepare_read_iterator() but there's also the call to ->prepare_read()
which I think can all be combined.

(And I've just realised that the patch I asked syzbot to test has a bug in it)

David


      parent reply	other threads:[~2024-12-04 14:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02  9:39 [PATCH v2] netfs: fix kernel BUG in iov_iter_revert() Dmitry Antipov
2024-12-04  9:56 ` syzbot program that crashes netfslib can also crash fuse David Howells
2024-12-04 12:41   ` Miklos Szeredi
2024-12-04 13:13     ` Dmitry Antipov
2024-12-04 13:41     ` David Howells
2024-12-06 12:41     ` Bernd Schubert
2024-12-13 16:13       ` Miklos Szeredi
2024-12-04 14:03 ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1128190.1733320983@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=brauner@kernel.org \
    --cc=dmantipov@yandex.ru \
    --cc=jlayton@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=netfs@lists.linux.dev \
    --cc=syzbot+404b4b745080b6210c6c@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox