From: Dave Kleikamp <shaggy@austin.ibm.com>
To: Anton Altaparmakov <aia21@cam.ac.uk>
Cc: Christoph Hellwig <hch@lst.de>, Andrew Morton <akpm@osdl.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: + switch-ntfs-to-touch_atime.patch added to -mm tree
Date: Tue, 08 Nov 2005 09:17:11 -0600 [thread overview]
Message-ID: <1131463032.9387.10.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0511081037070.30743@hermes-1.csi.cam.ac.uk>
On Tue, 2005-11-08 at 10:41 +0000, Anton Altaparmakov wrote:
> How come inode_setattr() sets both c and mtime unconditionally but
> inode/file_update_time() makes the setting conditional on IS_NOCMTIME()
> being false?
>
> It seems that either they should always be set or they should never be
> set when IS_NOCMTIME() is true, and not be set half the time and not half
> the other time, no?
IS_NOCMTIME() is useful to network file systems (nfs specifically) that
rely on the server setting the ctime & mtime when the inode is modified.
Of course, if the ctime & mtime are explicitly set by setattr, the
client will need to change these fields.
Local file systems don't set S_NOCMTIME, so you will get the behavior
you want. (I don't know enough about fuse to see why it sets this
flag.)
--
David Kleikamp
IBM Linux Technology Center
next prev parent reply other threads:[~2005-11-08 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200511060035.jA60Zk1U004874@shell0.pdx.osdl.net>
[not found] ` <20051106041321.GC30958@lst.de>
[not found] ` <20051105203531.7b67c2d8.akpm@osdl.org>
[not found] ` <20051107034614.GB16058@lst.de>
[not found] ` <Pine.LNX.4.64.0511071013550.4659@hermes-1.csi.cam.ac.uk>
[not found] ` <20051107115914.GA24006@lst.de>
[not found] ` <Pine.LNX.4.64.0511072143430.13960@hermes-1.csi.cam.ac.uk>
2005-11-08 4:43 ` + switch-ntfs-to-touch_atime.patch added to -mm tree Christoph Hellwig
2005-11-08 9:47 ` Anton Altaparmakov
2005-11-08 10:59 ` Anton Altaparmakov
2005-11-08 10:41 ` Anton Altaparmakov
2005-11-08 15:17 ` Dave Kleikamp [this message]
2005-11-08 15:25 ` Trond Myklebust
2005-11-08 15:58 ` Anton Altaparmakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1131463032.9387.10.camel@kleikamp.austin.ibm.com \
--to=shaggy@austin.ibm.com \
--cc=aia21@cam.ac.uk \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).