From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Kleikamp Subject: Re: + switch-ntfs-to-touch_atime.patch added to -mm tree Date: Tue, 08 Nov 2005 09:17:11 -0600 Message-ID: <1131463032.9387.10.camel@kleikamp.austin.ibm.com> References: <200511060035.jA60Zk1U004874@shell0.pdx.osdl.net> <20051106041321.GC30958@lst.de> <20051105203531.7b67c2d8.akpm@osdl.org> <20051107034614.GB16058@lst.de> <20051107115914.GA24006@lst.de> <20051108044310.GC8531@lst.de> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Christoph Hellwig , Andrew Morton , linux-fsdevel@vger.kernel.org Return-path: Received: from e3.ny.us.ibm.com ([32.97.182.143]:14723 "EHLO e3.ny.us.ibm.com") by vger.kernel.org with ESMTP id S1030201AbVKHPRT (ORCPT ); Tue, 8 Nov 2005 10:17:19 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e3.ny.us.ibm.com (8.12.11/8.12.11) with ESMTP id jA8FHE1S014620 for ; Tue, 8 Nov 2005 10:17:14 -0500 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay02.pok.ibm.com (8.12.10/NCO/VERS6.7) with ESMTP id jA8FHERX085576 for ; Tue, 8 Nov 2005 10:17:14 -0500 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11/8.13.3) with ESMTP id jA8FHEVt022600 for ; Tue, 8 Nov 2005 10:17:14 -0500 To: Anton Altaparmakov In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 2005-11-08 at 10:41 +0000, Anton Altaparmakov wrote: > How come inode_setattr() sets both c and mtime unconditionally but > inode/file_update_time() makes the setting conditional on IS_NOCMTIME() > being false? > > It seems that either they should always be set or they should never be > set when IS_NOCMTIME() is true, and not be set half the time and not half > the other time, no? IS_NOCMTIME() is useful to network file systems (nfs specifically) that rely on the server setting the ctime & mtime when the inode is modified. Of course, if the ctime & mtime are explicitly set by setattr, the client will need to change these fields. Local file systems don't set S_NOCMTIME, so you will get the behavior you want. (I don't know enough about fuse to see why it sets this flag.) -- David Kleikamp IBM Linux Technology Center