From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Kleikamp Subject: Re: [PATCH] Remove read-only check from inode_update_time(). Date: Wed, 09 Nov 2005 17:04:11 -0600 Message-ID: <1131577451.21652.10.camel@kleikamp.austin.ibm.com> References: Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hch@lst.de Return-path: To: Anton Altaparmakov In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 2005-11-09 at 22:48 +0000, Anton Altaparmakov wrote: > Hi Andrew, > > The read-only check in inode_update_time() (or file_update_time() as it is > now in -mm) is unnecessary as the VFS better have done all the read-only > checks and aborted much earlier in the file write code paths where > inode/file_update_time() is only called from. I notice inode_update_time is called from pipe_writev. I don't know how likely it would be in practice, but wouldn't it be possible to write to a pipe on a read-only partition? In that case the read-only check still makes sense. > (In case you were not following the ntfs discussion, Christoph Hellwig > agreed that check is unnecessary and can be removed.) > > Patch against latest Linus git tree is below, please apply. If you prefer > a patch on top of Christoph's file_update_time() check please let me > know... > > Best regards, > > Anton -- David Kleikamp IBM Linux Technology Center