From: Dave Kleikamp <shaggy@austin.ibm.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Takashi Sato <sho@tnes.nec.co.jp>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: stat64 for over 2TB file returned invalid st_blocks
Date: Tue, 06 Dec 2005 08:51:51 -0600 [thread overview]
Message-ID: <1133880711.8895.23.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <1133880516.9040.6.camel@lade.trondhjem.org>
On Tue, 2005-12-06 at 09:48 -0500, Trond Myklebust wrote:
> On Tue, 2005-12-06 at 08:30 -0600, Dave Kleikamp wrote:
> > On Tue, 2005-12-06 at 21:42 +0900, Takashi Sato wrote:
> > > So I updated the patch. Any feedback and comments are welcome.
> >
> > I think it looks good. The only issue I have is that I agree with
> > Andreas that i_blocks should be of type sector_t. I find the case of
> > accessing very large files over nfs with CONFIG_LBD disabled to be very
> > unlikely.
>
> NO! sector_t is a block-device specific type. It does not belong in the
> generic inode.
OK. I withdraw my objection. The patch looks good to me.
--
David Kleikamp
IBM Linux Technology Center
next prev parent reply other threads:[~2005-12-06 14:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-06 12:42 stat64 for over 2TB file returned invalid st_blocks Takashi Sato
2005-12-06 14:30 ` Dave Kleikamp
2005-12-06 14:48 ` Trond Myklebust
2005-12-06 14:51 ` Dave Kleikamp [this message]
2005-12-06 21:24 ` Andreas Dilger
2005-12-07 0:59 ` Trond Myklebust
2005-12-07 10:57 ` Takashi Sato
2005-12-07 13:52 ` Trond Myklebust
2005-12-07 15:01 ` Dave Kleikamp
2005-12-07 15:34 ` Trond Myklebust
2005-12-07 16:34 ` Dave Kleikamp
2005-12-07 18:55 ` Trond Myklebust
2005-12-08 11:38 ` Takashi Sato
2005-12-08 14:27 ` Trond Myklebust
2005-12-08 14:50 ` Anton Altaparmakov
2005-12-08 15:03 ` Trond Myklebust
2005-12-10 11:22 ` Takashi Sato
[not found] <5eVqw-2ug-61@gated-at.bofh.it>
2005-12-03 2:19 ` Bodo Eggert
-- strict thread matches above, loose matches on Subject: below --
2005-12-01 12:00 Takashi Sato
2005-12-01 12:39 ` Jörn Engel
2005-12-01 12:52 ` Jörn Engel
2005-12-01 13:52 ` Avi Kivity
2005-12-01 14:32 ` Dave Kleikamp
2005-12-02 13:18 ` Takashi Sato
2005-12-02 14:11 ` Dave Kleikamp
2005-12-02 18:58 ` Andreas Dilger
2005-12-03 13:00 ` Takashi Sato
2005-12-05 8:11 ` Andreas Dilger
2005-12-05 12:35 ` Takashi Sato
2005-12-05 13:34 ` Trond Myklebust
2005-12-01 14:53 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1133880711.8895.23.camel@kleikamp.austin.ibm.com \
--to=shaggy@austin.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sho@tnes.nec.co.jp \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).