From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Kleikamp Subject: Re: stat64 for over 2TB file returned invalid st_blocks Date: Tue, 06 Dec 2005 08:51:51 -0600 Message-ID: <1133880711.8895.23.camel@kleikamp.austin.ibm.com> References: <000301c5fa62$8d1bb730$4168010a@bsd.tnes.nec.co.jp> <1133879435.8895.14.camel@kleikamp.austin.ibm.com> <1133880516.9040.6.camel@lade.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Takashi Sato , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Return-path: Received: from e34.co.us.ibm.com ([32.97.110.152]:47744 "EHLO e34.co.us.ibm.com") by vger.kernel.org with ESMTP id S1751670AbVLFOvy (ORCPT ); Tue, 6 Dec 2005 09:51:54 -0500 To: Trond Myklebust In-Reply-To: <1133880516.9040.6.camel@lade.trondhjem.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 2005-12-06 at 09:48 -0500, Trond Myklebust wrote: > On Tue, 2005-12-06 at 08:30 -0600, Dave Kleikamp wrote: > > On Tue, 2005-12-06 at 21:42 +0900, Takashi Sato wrote: > > > So I updated the patch. Any feedback and comments are welcome. > > > > I think it looks good. The only issue I have is that I agree with > > Andreas that i_blocks should be of type sector_t. I find the case of > > accessing very large files over nfs with CONFIG_LBD disabled to be very > > unlikely. > > NO! sector_t is a block-device specific type. It does not belong in the > generic inode. OK. I withdraw my objection. The patch looks good to me. -- David Kleikamp IBM Linux Technology Center