From: Dave Kleikamp <shaggy@austin.ibm.com>
To: akpm@osdl.org
Cc: torvalds@osdl.org, aia21@cantab.net, blaisorblade@yahoo.it,
dhowells@redhat.com, dwmw2@infradead.org, green@linuxhacker.ru,
hch@lst.de, jdike@addtoit.com, linux-fsdevel@vger.kernel.org,
miklos@szeredi.hu, neilb@cse.unsw.edu.au,
reiserfs-dev@namesys.com, rmk@arm.linux.org.uk,
trond.myklebust@fys.uio.no, zippel@linux-m68k.org
Subject: Re: [patch 146/233] fix possible PAGE_CACHE_SHIFT overflows
Date: Sun, 08 Jan 2006 13:37:56 -0600 [thread overview]
Message-ID: <1136749077.10599.2.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <200601080903.k0893GE9015082@shell0.pdx.osdl.net>
On Sun, 2006-01-08 at 01:03 -0800, akpm@osdl.org wrote:
> From: Andrew Morton <akpm@osdl.org>
>
> We've had two instances recently of overflows when doing
>
> 64_bit_value = (32_bit_value << PAGE_CACHE_SHIFT)
>
> I did a tree-wide grep of `<<.*PAGE_CACHE_SHIFT' and this is the result.
>
> - afs_rxfs_fetch_descriptor.offset is of type off_t, which seems broken.
>
> - jfs and jffs are limited to 4GB anyway.
What makes you say jfs is limited to 4GB? No matter. There shouldn't
be any problem in jfs anyway.
--
David Kleikamp
IBM Linux Technology Center
next prev parent reply other threads:[~2006-01-08 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-08 9:03 [patch 146/233] fix possible PAGE_CACHE_SHIFT overflows akpm
2006-01-08 9:13 ` Russell King
2006-01-08 19:37 ` Dave Kleikamp [this message]
2006-01-08 21:35 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1136749077.10599.2.camel@kleikamp.austin.ibm.com \
--to=shaggy@austin.ibm.com \
--cc=aia21@cantab.net \
--cc=akpm@osdl.org \
--cc=blaisorblade@yahoo.it \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=green@linuxhacker.ru \
--cc=hch@lst.de \
--cc=jdike@addtoit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neilb@cse.unsw.edu.au \
--cc=reiserfs-dev@namesys.com \
--cc=rmk@arm.linux.org.uk \
--cc=torvalds@osdl.org \
--cc=trond.myklebust@fys.uio.no \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).