From: Lee Schermerhorn <lee.schermerhorn@hp.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] 2.6.16-rc-mm4 reiser4 calls try_to_unmap() with 1 arg -- now takes 2
Date: Thu, 02 Feb 2006 15:54:04 -0500 [thread overview]
Message-ID: <1138913644.5204.54.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.61.0602022040020.10639@goblin.wat.veritas.com>
On Thu, 2006-02-02 at 20:46 +0000, Hugh Dickins wrote:
> On Thu, 2 Feb 2006, Lee Schermerhorn wrote:
>
> > Apparent race between reiser4 and direct migration patches in 16-rc1-
> > mm4.
> > Direct migration added arg to rmap.c:try_to_unmap()--int ignore_refs--
> > and
> > fixed up existing refs. reiser4 adds new call with single arg.
> >
> > One doesn't see this when building mm4 w/ reiser4 because the ref under
> > an
> > "#if REISER4_COPY_ON_CAPTURE" that is apparently not enabled. I just
> > noticed
> > it while looking at direct migration patches. So, this patch is
> > essentially
> > UNTESTED. Supplied simply to illustrate the location of the single arg
>
> That's worrying code to find down in a filesystem. But never mind,
> it refers to pte_chain_lock(), which hasn't existed since 2.6.5. So
> REISER4_COPY_ON_CAPTURE is long untested and should just be deleted.
>
> Hugh
OK. I had a 16-rc1-mm4 build problem earlier because of a similar patch
race between an SGI patch bundle and one of gregkh's patches [ATE_MAKE()
arg changes], so I just wanted to give folks a heads up.
Thanks for the response.
Lee
>
> >
> > Signed-off-by: Lee Schermerhorn <lee.schermerhorn@hp.com>
> >
> > Index: linux-2.6.16-rc1-mm4/fs/reiser4/txnmgr.c
> > ===================================================================
> > --- linux-2.6.16-rc1-mm4.orig/fs/reiser4/txnmgr.c 2006-01-31
> > 16:51:39.000000000 -0500
> > +++ linux-2.6.16-rc1-mm4/fs/reiser4/txnmgr.c 2006-02-02
> > 14:43:01.659744418 -0500
> > @@ -3693,7 +3693,7 @@ static int create_copy_and_replace(jnode
> > pte_chain_lock(page);
> >
> > if (page_mapped(page)) {
> > - result = try_to_unmap(page);
> > + result = try_to_unmap(page, 0);
> > if (result == SWAP_AGAIN) {
> > result = RETERR(-E_REPEAT);
>
prev parent reply other threads:[~2006-02-02 20:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-02 20:16 [PATCH] 2.6.16-rc-mm4 reiser4 calls try_to_unmap() with 1 arg -- now takes 2 Lee Schermerhorn
2006-02-02 20:46 ` Hugh Dickins
2006-02-02 20:54 ` Lee Schermerhorn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1138913644.5204.54.camel@localhost.localdomain \
--to=lee.schermerhorn@hp.com \
--cc=hugh@veritas.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).