From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH, RFC] lockd: stop abusing file_lock_list
Date: Tue, 14 Feb 2006 17:27:30 -0500 [thread overview]
Message-ID: <1139956050.7867.64.camel@lade.trondhjem.org> (raw)
In-Reply-To: <20060214192051.GA20751@lst.de>
On Tue, 2006-02-14 at 20:20 +0100, Christoph Hellwig wrote:
> Currently lockd directly access the file_lock_list from fs/locks.c.
> It does so to mark locks granted or reclaimable. This is very
> suboptimal, because a) lockd needs to poke into locks.c internals, and
> b) it needs to iterate over all locks in the system for marking locks
> granted or reclaimable.
>
> This patch adds lists for granted and reclaimable locks to the nlm_host
> structure instead, and adds locks to those.
Thanks! From a quick eyeballing of the code, it looks good.
I'll put it into the NFS_ALL stream for testing (and farm it out to
Andrew if all goes well).
Cheers
Trond
next prev parent reply other threads:[~2006-02-14 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-14 19:20 [PATCH, RFC] lockd: stop abusing file_lock_list Christoph Hellwig
2006-02-14 22:27 ` Trond Myklebust [this message]
2006-02-16 4:44 ` Trond Myklebust
2006-02-16 10:23 ` Jens Axboe
2006-02-16 13:46 ` Trond Myklebust
2006-02-16 13:57 ` Christoph Hellwig
2006-02-16 14:21 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1139956050.7867.64.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).