From: Dave Kleikamp <shaggy@austin.ibm.com>
To: Neil Brown <neilb@suse.de>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 004 of 4] Make address_space_operations->invalidatepage return void
Date: Mon, 13 Mar 2006 17:22:52 -0600 [thread overview]
Message-ID: <1142292172.9923.5.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <17429.64506.967102.246581@cse.unsw.edu.au>
On Tue, 2006-03-14 at 10:10 +1100, Neil Brown wrote:
> On Monday March 13, shaggy@austin.ibm.com wrote:
> > I'm a little concerned about adding a BUG_ON for something this function
> > used to allow, but it looks like the BUG_ON is valid. I'm asking myself
> > why did I add the test for PageWriteback in the first place.
>
> Yes.... as far as I can tell, ->invalidatepage is only called with
> the page locked, and with Writeback clear, so PageWriteback can never
> be true. So the BUG_ON should be a no-op.
Either I was being overly paranoid when I put in that test, or some code
previously called invalidatepage with Writeback set and it's since been
fixed.
> > I'll try to stress test jfs with these patches to see if I can trigger
> > the an oops here.
>
> Thanks. I'd be very interested if you do.
> I got on oops with a similar bug_on in the new nfs_invalidatepage and
> it turned out to be a bug in radixtree (which I had already found and
> fixed, but not in that source tree).
Aside from the jbd assert that Andrew fixed, my stress testing of jfs
was successful. I ACK the jfs-specific part of the patch.
--
David Kleikamp
IBM Linux Technology Center
prev parent reply other threads:[~2006-03-13 23:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-12 23:53 [PATCH 000 of 4] Introduction: VFS documentation and tidy up NeilBrown
2006-03-12 23:53 ` [PATCH 001 of 4] Update some VFS documentation NeilBrown
2006-03-13 0:22 ` Avishay Traeger
2006-03-13 4:14 ` [PATCH 001 of 4] Update some VFS documentation fix Neil Brown
2006-03-13 4:58 ` [PATCH 001 of 4] Update some VFS documentation Randy.Dunlap
2006-03-12 23:53 ` [PATCH 002 of 4] Honour AOP_TRUNCATE_PAGE returns in page_symlink NeilBrown
2006-03-12 23:53 ` [PATCH 003 of 4] Make address_space_operations->sync_page return void NeilBrown
2006-03-12 23:53 ` [PATCH 004 of 4] Make address_space_operations->invalidatepage " NeilBrown
2006-03-13 16:32 ` Dave Kleikamp
2006-03-13 19:13 ` Dave Kleikamp
2006-03-13 21:36 ` Andrew Morton
2006-03-13 23:05 ` Neil Brown
2006-03-13 23:10 ` Neil Brown
2006-03-13 23:22 ` Dave Kleikamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1142292172.9923.5.camel@kleikamp.austin.ibm.com \
--to=shaggy@austin.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).