Can I download testing programs for "shared subtree"?

Can I download testing programs for "shared subtree"?

[Tetsuo Handa]

Hello,

I'm working for improving Linux's security.
I'm developing a kernel patch that restricts mount operations.
And I want to confirm my kernel patch won't break shared-subtree functionality.

According to http://lwn.net/Articles/152285/ ,
Avantika Mathur has developed testing programs.
Is it possible to download the testing programs?

Regards.

Re: Can I download testing programs for "shared subtree"?

[Ram Pai]

On Mon, 2006-03-13 at 21:56 +0900, Tetsuo Handa wrote:
> Hello,
> 
> I'm working for improving Linux's security.
> I'm developing a kernel patch that restricts mount operations.
> And I want to confirm my kernel patch won't break shared-subtree functionality.
> 
> According to http://lwn.net/Articles/152285/ ,
> Avantika Mathur has developed testing programs.
> Is it possible to download the testing programs?

Yes the testsuites are at 
http://www.sudhaa.com/?path=~ram/readahead/sharedsubtree/TESTSUITE

also there is a tar version at

http://www.sudhaa.com/?path=~ram/readahead/sharedsubtree/TESTSUITE.tar.bz2

Are are at least two test cases that are wrong.

RP


> 
> Regards.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Can I download testing programs for "shared subtree"?

[Tetsuo Handa]

Hello.

Ram Pai wrote:
> Yes the testsuites are at
> http://www.sudhaa.com/?path=~ram/readahead/sharedsubtree/TESTSUITE
> also there is a tar version at
> http://www.sudhaa.com/?path=~ram/readahead/sharedsubtree/TESTSUITE.tar.bz2

Thank you.
I confirmed that my patch doesn't break shared-subtree functionality.

I noticed that there are a couple of mount requests that are rejected by my patch.
(My patch checks the realpath() of the requested directory
 and rejects if not permitted to mount on that directory.)
May be the requested directories didn't exist.
I will report the cause if I could find it.

Re: Can I download testing programs for "shared subtree"?

[Tetsuo Handa]

Hello.

> I noticed that there are a couple of mount requests that are rejected by my patch.
> May be the requested directories didn't exist.
> I will report the cause if I could find it.

I made my kernel to report mount requests on nonexistent directory.
The following is the change I made to the testing programs.
Are these missing directories intended?

----- Start of patch -----
diff -ur TESTSUITE.org/testcases/move/test05 TESTSUITE/testcases/move/test05
--- TESTSUITE.org/testcases/move/test05	2005-09-27 07:10:32.000000000 +0900
+++ TESTSUITE/testcases/move/test05	2006-03-17 11:40:28.000000000 +0900
@@ -56,6 +56,7 @@
 check -n dir/grandchild parent2/child2/grandchild
 check -n share1/grandchild parent2/child2/grandchild
 
+mkdir -p share2/grandchild/a
 mount --bind $disk2 share2/grandchild/a
 
 check parent2/child2/grandchild/a share2/child2/grandchild/a
diff -ur TESTSUITE.org/testcases/move/test09 TESTSUITE/testcases/move/test09
--- TESTSUITE.org/testcases/move/test09	2005-09-27 07:10:32.000000000 +0900
+++ TESTSUITE/testcases/move/test09	2006-03-17 11:36:36.000000000 +0900
@@ -57,6 +57,7 @@
 check -n dir/grandchild parent2/child2/grandchild
 check -n share1/grandchild parent2/child2/grandchild
 
+mkdir -p share2/grandchild/a
 mount --bind $disk2 share2/grandchild/a
 
 check parent2/child2/grandchild/a share2/child2/grandchild/a
diff -ur TESTSUITE.org/testcases/move/test21 TESTSUITE/testcases/move/test21
--- TESTSUITE.org/testcases/move/test21	2005-09-27 07:10:32.000000000 +0900
+++ TESTSUITE/testcases/move/test21	2006-03-17 11:37:18.000000000 +0900
@@ -55,6 +55,7 @@
 
 check parent2/b parent2/a/b parent2/a/a/b
 
+mkdir -p parent1/a/c 
 mount --bind $disk3 parent1/a/c 
 
 check parent2/c parent2/a/c parent2/a/a/c
diff -ur TESTSUITE.org/testcases/rbind/test08 TESTSUITE/testcases/rbind/test08
--- TESTSUITE.org/testcases/rbind/test08	2005-09-27 07:10:32.000000000 +0900
+++ TESTSUITE/testcases/rbind/test08	2006-03-17 11:48:28.000000000 +0900
@@ -51,16 +51,18 @@
 
 check -n  parent1/child1 share1/child1
 
-mkdir parent2/child2
+mkdir -p parent2/child2
 
 mount --rbind parent1/child1 parent2/child2
 
+mkdir -p parent2/child2
 check parent1/child1 parent2/child2
 
 mount --rbind $disk2 parent1/child1/a
 
 check -n  parent1/child1/a parent2/child2/a
 
+mkdir -p parent2/child2/b
 mount --rbind $disk3 parent2/child2/b
 
 check -n parent1/child1/b parent2/child2/b
----- End of patch -----

Although I made directories as above, I couldn't suppress the following two cases.

    /root/TESTSUITE/testcases/rbind/test08 /bin/mount requested mount on nonexistent parent2/child2
    /root/TESTSUITE/testcases/rbind/test08 /bin/mount requested mount on nonexistent parent2/child2/b

Also, I had to run the following command for several times whenever I ran the testing programs.

    grep TESTSUITE /proc/mounts | awk ' { print $2 } ' | xargs umount --

Thank you.

Re: Can I download testing programs for "shared subtree"?

[Ram Pai]

On Fri, 2006-03-17 at 20:19 +0900, Tetsuo Handa wrote:
> Hello.
> 
> > I noticed that there are a couple of mount requests that are rejected by my patch.
> > May be the requested directories didn't exist.
> > I will report the cause if I could find it.

If you are seeing some warning and missing directories with your patch,
which you did not see without the patch, you will have to analyse the
behavior carefully.

That said the testcases needs fixing too. It leaves too many mounts
around which needs fixing.
rbind/test08 has issues for sure which needs to be analysed. and there
is one more move/test14 test case which needs to be analysed.

Avantika developed these testcases. Avantika, can you help us with this?
Thanks,
RP



> 
> I made my kernel to report mount requests on nonexistent directory.
> The following is the change I made to the testing programs.
> Are these missing directories intended?
> 
> ----- Start of patch -----
> diff -ur TESTSUITE.org/testcases/move/test05 TESTSUITE/testcases/move/test05
> --- TESTSUITE.org/testcases/move/test05	2005-09-27 07:10:32.000000000 +0900
> +++ TESTSUITE/testcases/move/test05	2006-03-17 11:40:28.000000000 +0900
> @@ -56,6 +56,7 @@
>  check -n dir/grandchild parent2/child2/grandchild
>  check -n share1/grandchild parent2/child2/grandchild
>  
> +mkdir -p share2/grandchild/a
>  mount --bind $disk2 share2/grandchild/a
>  
>  check parent2/child2/grandchild/a share2/child2/grandchild/a
> diff -ur TESTSUITE.org/testcases/move/test09 TESTSUITE/testcases/move/test09
> --- TESTSUITE.org/testcases/move/test09	2005-09-27 07:10:32.000000000 +0900
> +++ TESTSUITE/testcases/move/test09	2006-03-17 11:36:36.000000000 +0900
> @@ -57,6 +57,7 @@
>  check -n dir/grandchild parent2/child2/grandchild
>  check -n share1/grandchild parent2/child2/grandchild
>  
> +mkdir -p share2/grandchild/a
>  mount --bind $disk2 share2/grandchild/a
>  
>  check parent2/child2/grandchild/a share2/child2/grandchild/a
> diff -ur TESTSUITE.org/testcases/move/test21 TESTSUITE/testcases/move/test21
> --- TESTSUITE.org/testcases/move/test21	2005-09-27 07:10:32.000000000 +0900
> +++ TESTSUITE/testcases/move/test21	2006-03-17 11:37:18.000000000 +0900
> @@ -55,6 +55,7 @@
>  
>  check parent2/b parent2/a/b parent2/a/a/b
>  
> +mkdir -p parent1/a/c 
>  mount --bind $disk3 parent1/a/c 
>  
>  check parent2/c parent2/a/c parent2/a/a/c
> diff -ur TESTSUITE.org/testcases/rbind/test08 TESTSUITE/testcases/rbind/test08
> --- TESTSUITE.org/testcases/rbind/test08	2005-09-27 07:10:32.000000000 +0900
> +++ TESTSUITE/testcases/rbind/test08	2006-03-17 11:48:28.000000000 +0900
> @@ -51,16 +51,18 @@
>  
>  check -n  parent1/child1 share1/child1
>  
> -mkdir parent2/child2
> +mkdir -p parent2/child2
>  
>  mount --rbind parent1/child1 parent2/child2
>  
> +mkdir -p parent2/child2
>  check parent1/child1 parent2/child2
>  
>  mount --rbind $disk2 parent1/child1/a
>  
>  check -n  parent1/child1/a parent2/child2/a
>  
> +mkdir -p parent2/child2/b
>  mount --rbind $disk3 parent2/child2/b
>  
>  check -n parent1/child1/b parent2/child2/b
> ----- End of patch -----
> 
> Although I made directories as above, I couldn't suppress the following two cases.
> 
>     /root/TESTSUITE/testcases/rbind/test08 /bin/mount requested mount on nonexistent parent2/child2
>     /root/TESTSUITE/testcases/rbind/test08 /bin/mount requested mount on nonexistent parent2/child2/b
> 
> Also, I had to run the following command for several times whenever I ran the testing programs.
> 
>     grep TESTSUITE /proc/mounts | awk ' { print $2 } ' | xargs umount --
> 
> Thank you.