From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ram Pai Subject: Re: Can I download testing programs for "shared subtree"? Date: Fri, 17 Mar 2006 12:38:38 -0800 Message-ID: <1142627918.4809.141.camel@localhost> References: <200603132156.BED56868.MFGTtYSOFPEtJNMVGW@I-love.SAKURA.ne.jp> <1142287940.4737.49.camel@localhost> <200603142015.AHF73366.TSFYMtGJOPFVMNtGWE@I-love.SAKURA.ne.jp> <200603172019.BBI87068.WFtOVStNMGMPFETGYJ@I-love.SAKURA.ne.jp> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Avantika Mathur , linux-fsdevel@vger.kernel.org Return-path: Received: from e33.co.us.ibm.com ([32.97.110.151]:3255 "EHLO e33.co.us.ibm.com") by vger.kernel.org with ESMTP id S932152AbWCQUis (ORCPT ); Fri, 17 Mar 2006 15:38:48 -0500 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e33.co.us.ibm.com (8.12.11/8.12.11) with ESMTP id k2HKcimD013233 for ; Fri, 17 Mar 2006 15:38:44 -0500 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by westrelay02.boulder.ibm.com (8.12.10/NCO/VER6.8) with ESMTP id k2HKZnAg262084 for ; Fri, 17 Mar 2006 13:35:49 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id k2HKciHd001793 for ; Fri, 17 Mar 2006 13:38:44 -0700 To: Tetsuo Handa In-Reply-To: <200603172019.BBI87068.WFtOVStNMGMPFETGYJ@I-love.SAKURA.ne.jp> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, 2006-03-17 at 20:19 +0900, Tetsuo Handa wrote: > Hello. > > > I noticed that there are a couple of mount requests that are rejected by my patch. > > May be the requested directories didn't exist. > > I will report the cause if I could find it. If you are seeing some warning and missing directories with your patch, which you did not see without the patch, you will have to analyse the behavior carefully. That said the testcases needs fixing too. It leaves too many mounts around which needs fixing. rbind/test08 has issues for sure which needs to be analysed. and there is one more move/test14 test case which needs to be analysed. Avantika developed these testcases. Avantika, can you help us with this? Thanks, RP > > I made my kernel to report mount requests on nonexistent directory. > The following is the change I made to the testing programs. > Are these missing directories intended? > > ----- Start of patch ----- > diff -ur TESTSUITE.org/testcases/move/test05 TESTSUITE/testcases/move/test05 > --- TESTSUITE.org/testcases/move/test05 2005-09-27 07:10:32.000000000 +0900 > +++ TESTSUITE/testcases/move/test05 2006-03-17 11:40:28.000000000 +0900 > @@ -56,6 +56,7 @@ > check -n dir/grandchild parent2/child2/grandchild > check -n share1/grandchild parent2/child2/grandchild > > +mkdir -p share2/grandchild/a > mount --bind $disk2 share2/grandchild/a > > check parent2/child2/grandchild/a share2/child2/grandchild/a > diff -ur TESTSUITE.org/testcases/move/test09 TESTSUITE/testcases/move/test09 > --- TESTSUITE.org/testcases/move/test09 2005-09-27 07:10:32.000000000 +0900 > +++ TESTSUITE/testcases/move/test09 2006-03-17 11:36:36.000000000 +0900 > @@ -57,6 +57,7 @@ > check -n dir/grandchild parent2/child2/grandchild > check -n share1/grandchild parent2/child2/grandchild > > +mkdir -p share2/grandchild/a > mount --bind $disk2 share2/grandchild/a > > check parent2/child2/grandchild/a share2/child2/grandchild/a > diff -ur TESTSUITE.org/testcases/move/test21 TESTSUITE/testcases/move/test21 > --- TESTSUITE.org/testcases/move/test21 2005-09-27 07:10:32.000000000 +0900 > +++ TESTSUITE/testcases/move/test21 2006-03-17 11:37:18.000000000 +0900 > @@ -55,6 +55,7 @@ > > check parent2/b parent2/a/b parent2/a/a/b > > +mkdir -p parent1/a/c > mount --bind $disk3 parent1/a/c > > check parent2/c parent2/a/c parent2/a/a/c > diff -ur TESTSUITE.org/testcases/rbind/test08 TESTSUITE/testcases/rbind/test08 > --- TESTSUITE.org/testcases/rbind/test08 2005-09-27 07:10:32.000000000 +0900 > +++ TESTSUITE/testcases/rbind/test08 2006-03-17 11:48:28.000000000 +0900 > @@ -51,16 +51,18 @@ > > check -n parent1/child1 share1/child1 > > -mkdir parent2/child2 > +mkdir -p parent2/child2 > > mount --rbind parent1/child1 parent2/child2 > > +mkdir -p parent2/child2 > check parent1/child1 parent2/child2 > > mount --rbind $disk2 parent1/child1/a > > check -n parent1/child1/a parent2/child2/a > > +mkdir -p parent2/child2/b > mount --rbind $disk3 parent2/child2/b > > check -n parent1/child1/b parent2/child2/b > ----- End of patch ----- > > Although I made directories as above, I couldn't suppress the following two cases. > > /root/TESTSUITE/testcases/rbind/test08 /bin/mount requested mount on nonexistent parent2/child2 > /root/TESTSUITE/testcases/rbind/test08 /bin/mount requested mount on nonexistent parent2/child2/b > > Also, I had to run the following command for several times whenever I ran the testing programs. > > grep TESTSUITE /proc/mounts | awk ' { print $2 } ' | xargs umount -- > > Thank you.