From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F3B5C04AB4 for ; Fri, 17 May 2019 07:13:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF8E420833 for ; Fri, 17 May 2019 07:13:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728060AbfEQHN3 (ORCPT ); Fri, 17 May 2019 03:13:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38550 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727386AbfEQHN2 (ORCPT ); Fri, 17 May 2019 03:13:28 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 97937308FF32; Fri, 17 May 2019 07:13:28 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-61.rdu2.redhat.com [10.10.120.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id E59555D6A9; Fri, 17 May 2019 07:13:26 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <155800752418.4037.9567789434648701032.stgit@warthog.procyon.org.uk> <20190516162259.GB17978@ZenIV.linux.org.uk> <20190516163151.urrmrueugockxtdy@brauner.io> <20190516165021.GD17978@ZenIV.linux.org.uk> To: Christian Brauner Cc: dhowells@redhat.com, Al Viro , torvalds@linux-foundation.org, Arnd Bergmann , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api Subject: Re: [PATCH 0/4] uapi, vfs: Change the mount API UAPI [ver #2] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <11454.1558077206.1@warthog.procyon.org.uk> Date: Fri, 17 May 2019 08:13:26 +0100 Message-ID: <11455.1558077206@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Fri, 17 May 2019 07:13:28 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Christian Brauner wrote: > If you still prefer to have cloexec flags > for the 4 new syscalls then yes, > if they could at least all have the same name > (FSMOUNT_CLOEXEC?) that would be good. They don't all have the same value (see OPEN_TREE_CLOEXEC). Note that I also don't want to blindly #define them to O_CLOEXEC because it's not necessarily the same value on all arches. Currently it can be 02000000, 010000000 or 0x400000 for instance, which means that if it's sharing a mask with other flags, at least three bits have to be reserved for it or we have to have arch-dependent bit juggling. One thing I like about your approach of just making them O_CLOEXEC by default and removing the constants is that it avoids this mess entirely. David