From: Mingming Cao <cmm@us.ibm.com>
To: akpm@osdl.org
Cc: kiran@scalex86.org, LaurentVivier@wanadoo.fr, sct@redhat.com,
linux-kernel@vger.kernel.org,
ext2-devel <ext2-devel@lists.sourceforge.net>,
linux-fsdevel@vger.kernel.org
Subject: [PATCH 2/2] ext3 free blocks counter initialization fix
Date: Fri, 21 Apr 2006 07:59:10 -0700 [thread overview]
Message-ID: <1145631550.4478.11.camel@localhost.localdomain> (raw)
In-Reply-To: <1144691947.3964.54.camel@dyn9047017067.beaverton.ibm.com>
[PATCH 2] - Change ext3 to make use of the new percpu counter initialize
routine to init the free blocks counter, instead of using
percpu_counter_mod() indirectly.
Signed-Off-By: Mingming Cao <cmm@us.ibm.com>
---
linux-2.6.16-cmm/fs/ext3/super.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff -puN fs/ext3/super.c~ext3_64bit_percpu_counter_fix fs/ext3/super.c
--- linux-2.6.16/fs/ext3/super.c~ext3_64bit_percpu_counter_fix
2006-04-21 00:02:45.000000000 -0700
+++ linux-2.6.16-cmm/fs/ext3/super.c 2006-04-21 00:02:45.000000000 -0700
@@ -1583,9 +1583,6 @@ static int ext3_fill_super (struct super
goto failed_mount;
}
- percpu_counter_init(&sbi->s_freeblocks_counter);
- percpu_counter_init(&sbi->s_freeinodes_counter);
- percpu_counter_init(&sbi->s_dirs_counter);
bgl_lock_init(&sbi->s_blockgroup_lock);
for (i = 0; i < db_count; i++) {
@@ -1727,11 +1724,11 @@ static int ext3_fill_super (struct super
test_opt(sb,DATA_FLAGS) == EXT3_MOUNT_ORDERED_DATA ? "ordered":
"writeback");
- percpu_counter_mod(&sbi->s_freeblocks_counter,
+ percpu_counter_ll_init(&sbi->s_freeblocks_counter,
ext3_count_free_blocks(sb));
- percpu_counter_mod(&sbi->s_freeinodes_counter,
+ percpu_counter_ll_init(&sbi->s_freeinodes_counter,
ext3_count_free_inodes(sb));
- percpu_counter_mod(&sbi->s_dirs_counter,
+ percpu_counter_ll_init(&sbi->s_dirs_counter,
ext3_count_dirs(sb));
lock_kernel();
_
next prev parent reply other threads:[~2006-04-21 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-10 17:59 [RFC][PATCH 1/3] per cpu counter fixes for unsigned long type counter overflow Mingming Cao
2006-04-10 22:18 ` Andrew Morton
2006-04-11 1:09 ` Mingming Cao
2006-04-11 7:54 ` Andreas Dilger
2006-04-11 17:23 ` Mingming Cao
2006-04-21 14:59 ` Mingming Cao [this message]
2006-04-24 22:51 ` [PATCH 2/2] Set initial value when calling percpu counter initialization routine Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145631550.4478.11.camel@localhost.localdomain \
--to=cmm@us.ibm.com \
--cc=LaurentVivier@wanadoo.fr \
--cc=akpm@osdl.org \
--cc=ext2-devel@lists.sourceforge.net \
--cc=kiran@scalex86.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).