From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [PATCH 13/16] GFS2: Makefiles and Kconfig
Date: Mon, 24 Apr 2006 14:24:41 +0100
Message-ID: <1145885081.3856.143.camel@quoit.chygwyn.com>
References: <1145636558.3856.118.camel@quoit.chygwyn.com>
	 <20060421164309.GE19754@stusta.de>  <20060421230035.GA11190@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Adrian Bunk <bunk@stusta.de>, Andrew Morton <akpm@osdl.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([66.187.233.31]:33515 "EHLO mx1.redhat.com")
	by vger.kernel.org with ESMTP id S1750780AbWDXNQL (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 24 Apr 2006 09:16:11 -0400
To: Greg KH <greg@kroah.com>
In-Reply-To: <20060421230035.GA11190@kroah.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Hi,

On Fri, 2006-04-21 at 16:00 -0700, Greg KH wrote:
> On Fri, Apr 21, 2006 at 06:43:09PM +0200, Adrian Bunk wrote:
> > > --- /dev/null
> > > +++ b/fs/gfs2/Kconfig
> > > @@ -0,0 +1,46 @@
> > > +config GFS2_FS
> > > +        tristate "GFS2 file system support"
> > > +	default m
> > > +	depends on EXPERIMENTAL
> > > +        select FS_POSIX_ACL
> > > +        select SYSFS
> > >...
> > 
> > - tabs <-> spaces (tabs are correct)
> > - please remove the "default m"
> > - "depends on SYSFS" instead of the select
> 
> Why do you depend on sysfs at all?  If it's not enabled, your code
> should still build just fine, right?  If not, please let us know and we
> will fix the build error in the sysfs.h header file.
> 
> thanks,
> 
> greg k-h

I've removed this dependency now. Thanks for pointing this out,

Steve.