From: Steven Whitehouse <swhiteho@redhat.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Andrew Morton <akpm@osdl.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 13/16] GFS2: Makefiles and Kconfig
Date: Mon, 24 Apr 2006 14:27:47 +0100 [thread overview]
Message-ID: <1145885267.3856.147.camel@quoit.chygwyn.com> (raw)
In-Reply-To: <20060421210139.GB26949@mars.ravnborg.org>
Hi,
On Fri, 2006-04-21 at 23:01 +0200, Sam Ravnborg wrote:
> > --- /dev/null
> > +++ b/fs/gfs2/Makefile
> > @@ -0,0 +1,42 @@
> > +obj-$(CONFIG_GFS2_FS) += gfs2.o
> > +gfs2-y := \
> > + acl.o \
> > + bits.o \
> > + bmap.o \
> > + daemon.o \
> ...
> + trans.o \
> > + unlinked.o \
> > + util.o
> A fewer number of lines please.
> gfs2-y := acl.o bits.o bmap.o
> ...
> gfs2-y += trans.o unlinked.o util.o
>
I've made it a fewer number of lines now:
http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6.git;a=commitdiff;h=b5ea3e1ef307548bdd40fff6aba5fc96b002f284
>
> > +
> > +obj-$(CONFIG_GFS2_FS_LOCKING_NOLOCK) += locking/nolock/
> > +obj-$(CONFIG_GFS2_FS_LOCKING_DLM) += locking/dlm/
> Can we get rid f the locking sub-directory - maybe like this:
> +obj-$(CONFIG_GFS2_FS_LOCKING_NOLOCK) += no-lock/
> +obj-$(CONFIG_GFS2_FS_LOCKING_DLM += dlm-lock/
>
> Sam
I'd rather keep the subdirectory if there are no strong objections to
it. Its quite likely that as time goes on, GFS will gather both further
locking modules and even other non-locking related modules which would
fit more naturally as subdirectories of fs/gfs2 directly,
Steve.
prev parent reply other threads:[~2006-04-24 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-21 16:22 [PATCH 13/16] GFS2: Makefiles and Kconfig Steven Whitehouse
2006-04-21 16:43 ` Adrian Bunk
2006-04-21 16:49 ` Matthew Wilcox
2006-04-21 16:53 ` Adrian Bunk
2006-04-21 17:07 ` Matthew Wilcox
2006-04-21 20:56 ` Sam Ravnborg
2006-04-21 23:00 ` Greg KH
2006-04-24 13:24 ` Steven Whitehouse
2006-04-24 13:32 ` Steven Whitehouse
2006-04-21 21:01 ` Sam Ravnborg
2006-04-24 13:27 ` Steven Whitehouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145885267.3856.147.camel@quoit.chygwyn.com \
--to=swhiteho@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).