From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Kleikamp Subject: Re: [PATCH 6/13: eCryptfs] Superblock operations Date: Fri, 05 May 2006 08:12:20 -0500 Message-ID: <1146834740.10109.9.camel@kleikamp.austin.ibm.com> References: <84144f020605040737k316fd5abva4476da69a65c084@mail.gmail.com> <20060504031755.GA28257@hellewell.homeip.net> <20060504033829.GE28613@hellewell.homeip.net> <23457.1146778849@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Pekka Enberg , Phillip Hellewell , Andrew Morton , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, toml@us.ibm.com, yoder1@us.ibm.com, James Morris , "Stephen C. Tweedie" , Erez Zadok Return-path: Received: from e34.co.us.ibm.com ([32.97.110.152]:16020 "EHLO e34.co.us.ibm.com") by vger.kernel.org with ESMTP id S1751102AbWEENMX (ORCPT ); Fri, 5 May 2006 09:12:23 -0400 To: David Howells In-Reply-To: <23457.1146778849@warthog.cambridge.redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 2006-05-04 at 22:40 +0100, David Howells wrote: > Pekka Enberg wrote: > > > > + ecryptfs_printk(KERN_DEBUG, "Enter; inode = [%p]\n", inode); > > > + crypt_stat = &(ECRYPTFS_INODE_TO_PRIVATE(inode))->crypt_stat; > > > + ecryptfs_destruct_crypt_stat(crypt_stat); > > > + kmem_cache_free(ecryptfs_inode_info_cache, > > > + ECRYPTFS_INODE_TO_PRIVATE(inode)); > > > > Better to introduce a local variable for CRYPTFS_INODE_TO_PRIVATE. > > More readable and smaller kernel text that way. > > But it may use more stack, which is a much more limited resource, so what you > suggest is not necessarily the best thing to do. I think either way it's coded, the compiler will probably store the result in a register. I would recommend the most readable approach (which I believe would be using a local variable) and leave the optimization to the compiler. > David Shaggy -- David Kleikamp IBM Linux Technology Center