From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [RFC][PATCH 07/27] sys_mkdirat(): collapse if() Date: Thu, 08 Jun 2006 08:10:40 -0700 Message-ID: <1149779440.4097.45.camel@localhost.localdomain> References: <20060608001013.0D041507@localhost.localdomain> <20060608001019.6ABD41A7@localhost.localdomain> <20060608104650.GE11996@MAIL.13thfloor.at> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, hch@infradead.org, trond.myklebust@fys.uio.no Return-path: Received: from e36.co.us.ibm.com ([32.97.110.154]:3038 "EHLO e36.co.us.ibm.com") by vger.kernel.org with ESMTP id S964863AbWFHPLh (ORCPT ); Thu, 8 Jun 2006 11:11:37 -0400 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e36.co.us.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k58FBaiW020203 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 8 Jun 2006 11:11:36 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by westrelay02.boulder.ibm.com (8.13.6/NCO/VER7.0) with ESMTP id k58FBUc7075408 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 8 Jun 2006 09:11:31 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k58FBZcu018943 for ; Thu, 8 Jun 2006 09:11:36 -0600 To: Herbert Poetzl In-Reply-To: <20060608104650.GE11996@MAIL.13thfloor.at> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 2006-06-08 at 12:46 +0200, Herbert Poetzl wrote: > On Wed, Jun 07, 2006 at 05:10:19PM -0700, Dave Hansen wrote: > > > > Take the entire "if (IS_ERR(tmp))" block, and use a goto, > > instead. > > > > This should not make any functional changes. > > AFAICR, my test tool was done before the *at funtions > were added to the kernel. did you extend it or test > them in addition to the normal tests? No, I didn't extend it. However, I believe all of the internal kernel implementations which are plain, like sys_mknod() call into the *at() variants. I could look at extending that test, but I think all of the code paths are still being exercised. I actually audited from the bottom up, looking for callers of the permission functions, and anywhere that checked an inode for a read-only superblock. -- Dave