From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [RFC][PATCH 19/27] sys_faccessat() elevate writer count Date: Thu, 08 Jun 2006 08:15:06 -0700 Message-ID: <1149779706.4097.52.camel@localhost.localdomain> References: <20060608001013.0D041507@localhost.localdomain> <20060608001029.80D57052@localhost.localdomain> <20060608110323.GI11996@MAIL.13thfloor.at> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, hch@infradead.org, trond.myklebust@fys.uio.no Return-path: Received: from e4.ny.us.ibm.com ([32.97.182.144]:36243 "EHLO e4.ny.us.ibm.com") by vger.kernel.org with ESMTP id S964867AbWFHPQD (ORCPT ); Thu, 8 Jun 2006 11:16:03 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k58FG2O0014626 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 8 Jun 2006 11:16:03 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.6/NCO/VER7.0) with ESMTP id k58FG2j6182504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 8 Jun 2006 11:16:02 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k58FG1XM025866 for ; Thu, 8 Jun 2006 11:16:02 -0400 To: Herbert Poetzl In-Reply-To: <20060608110323.GI11996@MAIL.13thfloor.at> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 2006-06-08 at 13:03 +0200, Herbert Poetzl wrote: > this is the first non-trivial change to the > condition checks (regarding goto out_path_release) > why didn't you break that out too? Honestly, it was because I did this one before I even tried to compile and boot the thing. Once I hit a bug or two, I started separating out the control structure changes from the actual addition of the write count changes. I admit, it is a bit inconsistent. I can definitely break things out further in the next set, but I thought 27 patches was enough for now. ;) -- Dave