From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [RFC][PATCH 23/27] elevate write count over calls to vfs_rename() Date: Thu, 08 Jun 2006 08:24:31 -0700 Message-ID: <1149780272.4097.64.camel@localhost.localdomain> References: <20060608001013.0D041507@localhost.localdomain> <20060608001036.3B8AEAE2@localhost.localdomain> <20060608112325.GM11996@MAIL.13thfloor.at> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, hch@infradead.org, trond.myklebust@fys.uio.no Return-path: Received: from e33.co.us.ibm.com ([32.97.110.151]:34198 "EHLO e33.co.us.ibm.com") by vger.kernel.org with ESMTP id S964875AbWFHPZ2 (ORCPT ); Thu, 8 Jun 2006 11:25:28 -0400 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e33.co.us.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k58FPRWd002933 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 8 Jun 2006 11:25:28 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by westrelay02.boulder.ibm.com (8.13.6/NCO/VER7.0) with ESMTP id k58FPMR6207238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 8 Jun 2006 09:25:22 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k58FPQeu011698 for ; Thu, 8 Jun 2006 09:25:27 -0600 To: Herbert Poetzl In-Reply-To: <20060608112325.GM11996@MAIL.13thfloor.at> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 2006-06-08 at 13:23 +0200, Herbert Poetzl wrote: > On Wed, Jun 07, 2006 at 05:10:36PM -0700, Dave Hansen wrote: > > diff -puN fs/namei.c~elevate-writers-vfs_rename-part1 fs/namei.c > > --- lxc/fs/namei.c~elevate-writers-vfs_rename-part1 2006-06-07 16:53:26.000000000 -0700 > > +++ lxc-dave/fs/namei.c 2006-06-07 16:53:26.000000000 -0700 > > @@ -2507,29 +2507,37 @@ static int do_rename(int olddfd, const c > > if (error) > > goto exit; > > > > - error = do_path_lookup(newdfd, newname, LOOKUP_PARENT, &newnd); > > + error = mnt_want_write(oldnd.mnt); > > if (error) > > goto exit1; > > same here, I'd suspect it changes the return code > for the case where the 'files' reside on different > mount points from -EXDEV and for the busy case > from -EBUSY to -EROFS .... > > don't get me wrong, I'm probably fine with those > changes if they are consistant and do not depend > on whether the inode is RO or the entire mnt point I think I might be able to fix this one up a bit by changing the order around. I'll have a good look at it. -- Dave