From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [RFC][PATCH 23/27] elevate write count over calls to vfs_rename() Date: Mon, 12 Jun 2006 11:29:24 -0700 Message-ID: <1150136964.13644.64.camel@localhost.localdomain> References: <20060608001013.0D041507@localhost.localdomain> <20060608001036.3B8AEAE2@localhost.localdomain> <20060612181804.GE27946@ftp.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, herbert@13thfloor.at, hch@infradead.org, trond.myklebust@fys.uio.no Return-path: Received: from e36.co.us.ibm.com ([32.97.110.154]:48817 "EHLO e36.co.us.ibm.com") by vger.kernel.org with ESMTP id S1752164AbWFLSuN (ORCPT ); Mon, 12 Jun 2006 14:50:13 -0400 Received: from westrelay02.boulder.ibm.com (westrelay02.boulder.ibm.com [9.17.195.11]) by e36.co.us.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k5CIoCiE013871 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 12 Jun 2006 14:50:13 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by westrelay02.boulder.ibm.com (8.13.6/NCO/VER7.0) with ESMTP id k5CIl4QG278800 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 12 Jun 2006 12:50:01 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k5CIUWrk022414 for ; Mon, 12 Jun 2006 12:30:33 -0600 To: Al Viro In-Reply-To: <20060612181804.GE27946@ftp.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 2006-06-12 at 19:18 +0100, Al Viro wrote: > On Wed, Jun 07, 2006 at 05:10:36PM -0700, Dave Hansen wrote: > > + error = mnt_want_write(oldnd.mnt); > > if (error) > > goto exit1; > > > > + error = do_path_lookup(newdfd, newname, LOOKUP_PARENT, &newnd); > > + if (error) > > + goto exit2; > > + > > + error = mnt_want_write(oldnd.mnt); > > WTF? Why raise it twice? That's a bug. The second raise should be for newnd.mnt. The fix will be there in the next set. -- Dave