Re: [PATCH 20/21] AUTOFS: Make sure all dentries refs are released before calling kill_anon_super()

[Ian Kent <raven@themaw.net>]

On Thu, 2006-07-06 at 20:23 -0700, Andrew Morton wrote:
> On Fri, 07 Jul 2006 11:15:55 +0800
> Ian Kent <raven@themaw.net> wrote:
> 
> > On Thu, 2006-07-06 at 18:56 -0700, Andrew Morton wrote:
> > > On Thu, 06 Jul 2006 11:11:07 -0400
> > > Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
> > > 
> > > > From: David Howells <dhowells@redhat.com>
> > > > 
> > > > Make sure all dentries refs are released before calling kill_anon_super() so
> > > > that the assumption that generic_shutdown_super() can completely destroy the
> > > > dentry tree for there will be no external references holds true.
> > > > 
> > > > What was being done in the put_super() superblock op, is now done in the
> > > > kill_sb() filesystem op instead, prior to calling kill_anon_super().
> > > > 
> > > > This makes the struct autofs_sb_info::root member variable redundant (since
> > > > sb->s_root is still available), and so that is removed.  The calls to
> > > > shrink_dcache_sb() are also removed since they're also redundant as
> > > > shrink_dcache_for_umount() will now be called after the cleanup routine.
> > > > 
> > > 
> > > AFAIK, Ian is still off thinking about this one?
> > 
> > The patch looks fine to me but I wanted to give it a basic sanity test
> > before ACKing it. I haven't got to that yet partly because I wasn't sure
> > if the two patches from David would stand alone. Will they or will I
> > need to apply Davids whole patch set?
> 
> I expect this patch is standalone, but it's not really useful or
> interesting to test it unless [21/21] is also applied, because the two
> patches will tend to stick together.  Plus this one is supposed to fix a
> umount/shutdown-time BUG in the other.

OK. I'm with it now.

David copied me on two patches, the other was:
[PATCH 1/2] VFS: Destroy the dentries contributed by a superblock on
unmounting

I see that these correspond to patches 20 and 21 of Tronds 2.6.18-rc1
submission.

I was expecting that both would be required at least, so I'll try with
these two before I try anything else.

Thanks.
Ian