From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [RFC/PATCH] revoke/frevoke system calls V2
Date: Wed, 09 Aug 2006 19:36:45 +0100
Message-ID: <1155148605.5729.251.camel@localhost.localdomain>
References: <Pine.LNX.4.58.0607271722430.4663@sbz-30.cs.Helsinki.FI>
	 <20060805122936.GC5417@ucw.cz> <20060807101745.61f21826.froese@gmx.de>
	 <84144f020608070251j2e14e909v8a18f62db85ff3d4@mail.gmail.com>
	 <20060807224144.3bb64ac4.froese@gmx.de>
	 <Pine.LNX.4.64.0608071720510.29055@turbotaz.ourhouse>
	 <1155039338.5729.21.camel@localhost.localdomain>
	 <20060809104159.1f1737d3.froese@gmx.de>
	 <1155119999.5729.141.camel@localhost.localdomain>
	 <20060809200010.2404895a.froese@gmx.de>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Chase Venters <chase.venters@clientec.com>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Pavel Machek <pavel@ucw.cz>, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org, akpm@osdl.org,
	viro@zeniv.linux.org.uk, tytso@mit.edu, tigran@veritas.com
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:8392 "EHLO
	lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP
	id S1751152AbWHISRA (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 9 Aug 2006 14:17:00 -0400
To: Edgar Toernig <froese@gmx.de>
In-Reply-To: <20060809200010.2404895a.froese@gmx.de>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Ar Mer, 2006-08-09 am 20:00 +0200, ysgrifennodd Edgar Toernig:
> But anyway, correct me if I'm wrong, revoke (V2) not simply removes the
> pages from the mmaped area as truncating does (the vma stays);  revoke
> seems to completely remove the vma which is clearly a security bug.
> Future mappings may silently get mapped into the area of the revoked
> file without the app noticing it.  It may then hand out data of the new
> file still thinking it's sending the old one.

I agree with that point 100%.