From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, aviro@redhat.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
nfsv4@linux-nfs.org
Subject: Re: [RHEL5 PATCH 2/2] NFS: Represent 64-bit fileids as 64-bit inode numbers on 32-bit systems [try #2]
Date: Tue, 15 Aug 2006 12:28:30 -0400 [thread overview]
Message-ID: <1155659311.5657.2.camel@localhost> (raw)
In-Reply-To: <20060815152632.29222.66333.stgit@warthog.cambridge.redhat.com>
On Tue, 2006-08-15 at 16:26 +0100, David Howells wrote:
>
> - /* We set i_ino for the few things that still rely on it,
> - * such as stat(2) */
> - inode->i_ino = hash;
> + /* We set i_ino for the few things that still rely on it, such
> + * as printing messages; stat and filldir use the fileid
> + * directly since i_ino may not be large enough */
> + inode->i_ino = fattr->fileid;
Are there any plans to remove inode->i_ino? It would appear to have
outlived its usefulness.
Otherwise Acked...
Cheers,
Trond
next prev parent reply other threads:[~2006-08-15 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-15 15:26 [PATCH 0/2] Use 64-bit inode numbers internally in the kernel [try #2] David Howells
2006-08-15 15:26 ` [RHEL5 PATCH 1/2] VFS: Make filldir_t and struct kstat deal in 64-bit inode numbers " David Howells
2006-08-15 15:26 ` [RHEL5 PATCH 2/2] NFS: Represent 64-bit fileids as 64-bit inode numbers on 32-bit systems " David Howells
2006-08-15 16:28 ` Trond Myklebust [this message]
2006-08-16 0:22 ` [PATCH 0/2] Use 64-bit inode numbers internally in the kernel " Nathan Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155659311.5657.2.camel@localhost \
--to=trond.myklebust@fys.uio.no \
--cc=akpm@osdl.org \
--cc=aviro@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).