From mboxrd@z Thu Jan 1 00:00:00 1970 From: Trond Myklebust Subject: Re: [RHEL5 PATCH 2/2] NFS: Represent 64-bit fileids as 64-bit inode numbers on 32-bit systems [try #2] Date: Tue, 15 Aug 2006 12:28:30 -0400 Message-ID: <1155659311.5657.2.camel@localhost> References: <20060815152627.29222.71414.stgit@warthog.cambridge.redhat.com> <20060815152632.29222.66333.stgit@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: torvalds@osdl.org, akpm@osdl.org, aviro@redhat.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, nfsv4@linux-nfs.org Return-path: Received: from pat.uio.no ([129.240.10.4]:41351 "EHLO pat.uio.no") by vger.kernel.org with ESMTP id S965387AbWHOQ2w (ORCPT ); Tue, 15 Aug 2006 12:28:52 -0400 To: David Howells In-Reply-To: <20060815152632.29222.66333.stgit@warthog.cambridge.redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 2006-08-15 at 16:26 +0100, David Howells wrote: > > - /* We set i_ino for the few things that still rely on it, > - * such as stat(2) */ > - inode->i_ino = hash; > + /* We set i_ino for the few things that still rely on it, such > + * as printing messages; stat and filldir use the fileid > + * directly since i_ino may not be large enough */ > + inode->i_ino = fattr->fileid; Are there any plans to remove inode->i_ino? It would appear to have outlived its usefulness. Otherwise Acked... Cheers, Trond