From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Randy Dunlap" Subject: Re: [Ext2-devel] [PATCH 1/9] extents for ext4 Date: Tue, 15 Aug 2006 14:27:12 -0700 Message-ID: <1155677232.11401@shark.he.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Return-path: Received: from xenotime.net ([66.160.160.81]:29574 "HELO xenotime.net") by vger.kernel.org with SMTP id S1750723AbWHOV1T (ORCPT ); Tue, 15 Aug 2006 17:27:19 -0400 Received: from shark.he.net ([127.0.0.9]) by xenotime.net for ; Tue, 15 Aug 2006 14:27:12 -0700 To: Pavel Machek , "Randy.Dunlap" , Alex Tomas , Andrew Morton , cmm@us.ibm.com, linux-fsdevel@vger.kernel.org, ext2-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org > Hi! > > > > AM> - The existing comments could benefit from some rework by a > > > AM> native English speaker. > > > > > > could someone assist here, please? > > > > See if this helps. > > Patch applies on top of all ext4 patches from > > http://ext2.sourceforge.net/48bitext3/patches/latest/. > > > --- linux-2618-rc4-ext4.orig/include/linux/ext4_fs_extents.h > > +++ linux-2618-rc4-ext4/include/linux/ext4_fs_extents.h > > @@ -22,29 +22,29 @@ > > #include > > > > /* > > - * with AGRESSIVE_TEST defined capacity of index/leaf blocks > > - * become very little, so index split, in-depth growing and > > - * other hard changes happens much more often > > - * this is for debug purposes only > > + * With AGRESSIVE_TEST defined, the capacity of index/leaf blocks > > + * becomes very small, so index split, in-depth growing and > > + * other hard changes happen much more often. > > + * This is for debug purposes only. > > */ > > #define AGRESSIVE_TEST_ > > Using _ for disabling is unusual/nasty. Can't we simply #undef it? Yes, that's the right thing to do. The ext4dev people should do that. :) --- ~Randy