From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Woodhouse Subject: Re: [PATCH] BLOCK: Make it possible to disable the block layer Date: Thu, 24 Aug 2006 14:40:59 +0100 Message-ID: <1156426859.3012.36.camel@pmac.infradead.org> References: <1156425193.3012.32.camel@pmac.infradead.org> <32640.1156424442@warthog.cambridge.redhat.com> <778.1156426456@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Return-path: Received: from pentafluge.infradead.org ([213.146.154.40]:22691 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1751381AbWHXNlC (ORCPT ); Thu, 24 Aug 2006 09:41:02 -0400 To: David Howells In-Reply-To: <778.1156426456@warthog.cambridge.redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 2006-08-24 at 14:34 +0100, David Howells wrote: > Ah, but... The core kernel makes use of the certain header files, even when > their actual intended target is compiled as a module. If I just use > "CONFIG_foo" only, then the module won't compile as a module. So don't put it in the header file itself. Just do #ifdef CONFIG_foo #include #endif Better still, avoid the need for the external code to poke at fs-private header files at all. -- dwmw2