From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Kent Subject: Re: [PATCH 0/7] Permit filesystem local caching and NFS superblock sharing [try #13] Date: Tue, 05 Sep 2006 15:07:52 +0800 Message-ID: <1157440072.4133.14.camel@raven.themaw.net> References: <20060901195009.187af603.akpm@osdl.org> <20060831102127.8fb9a24b.akpm@osdl.org> <20060830135503.98f57ff3.akpm@osdl.org> <20060830125239.6504d71a.akpm@osdl.org> <20060830193153.12446.24095.stgit@warthog.cambridge.redhat.com> <27414.1156970238@warthog.cambridge.redhat.com> <9849.1157018310@warthog.cambridge.redhat.com> <9534.1157116114@warthog.cambridge.redhat.com> <20060901093451.87aa486d.akpm@osdl.org> <1157130044.5632.87.camel@localhost> <28945.1157370732@warthog.cambridge.redhat.com> <1157423027.5510.23.camel@localhost> <1157429219.3915.11.camel@raven.themaw.net> <1157432221.32412.41.camel@localhost> <1157438714.4133.0.camel@raven.themaw.net> Reply-To: Linux filesystem caching discussion list Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Andrew Morton , nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org, torvalds@osdl.org, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org Return-path: To: Trond Myklebust In-Reply-To: <1157438714.4133.0.camel@raven.themaw.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-cachefs-bounces@redhat.com Errors-To: linux-cachefs-bounces@redhat.com List-Id: linux-fsdevel.vger.kernel.org On Tue, 2006-09-05 at 14:45 +0800, Ian Kent wrote: > On Tue, 2006-09-05 at 00:57 -0400, Trond Myklebust wrote: > > On Tue, 2006-09-05 at 12:06 +0800, Ian Kent wrote: > > > > > > One way to fix this is to simply not hash the dentry when we're doing > > > > the O_EXCL intent optimisation, but rather to only hash it _after_ we've > > > > successfully created the file on the server. Something like the attached > > > > patch ought to do it. > > > > > > No. > > > > > > This patch simply marks the dentry negative and returns ENOMEM from the > > > lookup which, as would be expected, results in this error being returned > > > to userspace. > > > > Oops. You are right. I forgot to set res=NULL... > > Now returns EPERM. Sorry that's EACCES.