Linux filesystem development
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Andrew Morton <akpm@osdl.org>
Cc: autofs mailing list <autofs@linux.kernel.org>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] autofs4 - zero timeout prevents shutdown
Date: Tue, 19 Sep 2006 12:55:10 +0800	[thread overview]
Message-ID: <1158641710.3003.29.camel@raven.themaw.net> (raw)
In-Reply-To: <20060918213853.d4628ba0.akpm@osdl.org>

On Mon, 2006-09-18 at 21:38 -0700, Andrew Morton wrote:
> On Tue, 19 Sep 2006 12:33:52 +0800
> Ian Kent <raven@themaw.net> wrote:
> 
> > On Mon, 2006-09-18 at 21:11 -0700, Andrew Morton wrote:
> > > On Tue, 19 Sep 2006 11:48:15 +0800 (WST)
> > > Ian Kent <raven@themaw.net> wrote:
> > > 
> > > > If the timeout of an autofs mount is set to zero then umounts
> > > > are disabled. This works fine, however the kernel module checks
> > > > the expire timeout and goes no further if it is zero. This is
> > > > not the right thing to do at shutdown as the module is passed
> > > > an option to expire mounts regardless of their timeout setting.
> > > 
> > > Is this a new feature, or a regression since <when>?
> > 
> > It's a regression which I must have introduced a long time ago. I can go
> > back and check the kernels if you'd like more specific info.
> > 
> > It should work this way and a recent report alerted me to it.
> > 
> 
> Well..  I'm trying to work out if it's a 2.6.18 thing or whether we can
> hold it over.

I had a quick look and it appears to be present as far back as 2002/06
in 2.4. I'm a bit puzzled why I haven't seen it before as I'm sure I've
tested this over the years, never the less it looks so clearly wrong to
me know.

It's a bug fix and given it's been around so long, not a widely used.

Personally I'd like to get it into 2.6.18.
As always I'm happy with whatever decision you make.

Ian



      reply	other threads:[~2006-09-19  4:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-19  3:48 [PATCH] autofs4 - zero timeout prevents shutdown Ian Kent
2006-09-19  4:11 ` Andrew Morton
2006-09-19  4:33   ` Ian Kent
2006-09-19  4:38     ` Andrew Morton
2006-09-19  4:55       ` Ian Kent [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1158641710.3003.29.camel@raven.themaw.net \
    --to=raven@themaw.net \
    --cc=akpm@osdl.org \
    --cc=autofs@linux.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox