From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell Cattelan Subject: Re: [RFC PATCH 0/2] O_DIRECT locking rework Date: Tue, 24 Oct 2006 17:37:42 -0500 Message-ID: <1161729462.26171.1.camel@xenon.msp.redhat.com> References: <20061020183237.GA8674@think.oraclecorp.com> <20061024193435.GE12815@think.oraclecorp.com> <1161721711.18096.33.camel@dyn9047017100.beaverton.ibm.com> <20061024205024.GJ12815@think.oraclecorp.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-R2+kbd5qctgPL0O8dPRU" Cc: Badari Pulavarty , linux-fsdevel , akpm@osdl.org, Zach Brown Return-path: Received: from cattelan-host202.dsl.visi.com ([208.42.117.202]:35282 "EHLO slurp.thebarn.com") by vger.kernel.org with ESMTP id S1422765AbWJXWiD (ORCPT ); Tue, 24 Oct 2006 18:38:03 -0400 To: Chris Mason In-Reply-To: <20061024205024.GJ12815@think.oraclecorp.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org --=-R2+kbd5qctgPL0O8dPRU Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 2006-10-24 at 16:50 -0400, Chris Mason wrote: > On Tue, Oct 24, 2006 at 01:28:31PM -0700, Badari Pulavarty wrote: > > On Tue, 2006-10-24 at 15:34 -0400, Chris Mason wrote: > > > Hello, > > >=20 > > > Here is a new cut of my O_DIRECT locking rework. It has a much lower > > > cpu cost than the last set, and simple benchmarks no longer show a > > > regression here in system time. But, the complexity for inserting > > > placeholder pages has gone up. > > >=20 > > > I've also changed the way I test for a place holder page (from > > > mm/filemap.c): > > >=20 > > > static struct address_space placeholder_address_space; > > > #define PagePlaceHolder(page) ((page)->mapping =3D=3D &placeholder_ad= dress_space) > > >=20 > > > This is more stable than the last one but I'm just starting to run ra= ce > > > and load testing on it. > > >=20 > > > -chris > >=20 > > Gave it a spin with simple fsx tests and ran into .. >=20 > Thanks, I missed an i_mutex change. Let me audit mutexes coming in and > out again and resend. >=20 > I think the new rules should be: >=20 > reads: don't need i_mutex at all > writes: don't need i_mutex for io inside i_size. >=20 > Oh, and don't mess with i_mutex under DIO_OWN_LOCKING. Can we get rid of DIO_OWN_LOCKING altogether. It's horribly confusing and overload with regards to the create flag in get_blocks. > -chris > - > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" = in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >=20 --=20 Russell Cattelan --=-R2+kbd5qctgPL0O8dPRU Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (GNU/Linux) iD8DBQBFPpW1NRmM+OaGhBgRApgZAJ42E4+Orax4bV7jeY/kMl9K8qIDSACfQNoe 7v+Ux3Woj3onQtDbfGhEDCs= =db2p -----END PGP SIGNATURE----- --=-R2+kbd5qctgPL0O8dPRU--