From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Whitehouse Subject: Re: [PATCH] GFS2: don't panic needlessly Date: Mon, 30 Oct 2006 09:47:02 +0000 Message-ID: <1162201622.27980.234.camel@quoit.chygwyn.com> References: <20061027230348.GA4902@martell.zuzino.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Andrew Morton , linux-fsdevel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:60811 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S965503AbWJ3JmO (ORCPT ); Mon, 30 Oct 2006 04:42:14 -0500 To: Alexey Dobriyan In-Reply-To: <20061027230348.GA4902@martell.zuzino.mipt.ru> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Hi, Thanks for the patch. Now applied to the GFS2 git tree, Steve. On Sat, 2006-10-28 at 03:03 +0400, Alexey Dobriyan wrote: > First, SLAB_PANIC is unjustified. Second, all error propagating and backing out > is in place. > > Signed-off-by: Alexey Dobriyan > --- > > fs/gfs2/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > --- a/fs/gfs2/main.c > +++ b/fs/gfs2/main.c > @@ -84,8 +84,8 @@ static int __init init_gfs2_fs(void) > > gfs2_inode_cachep = kmem_cache_create("gfs2_inode", > sizeof(struct gfs2_inode), > - 0, (SLAB_RECLAIM_ACCOUNT| > - SLAB_PANIC|SLAB_MEM_SPREAD), > + 0, SLAB_RECLAIM_ACCOUNT| > + SLAB_MEM_SPREAD, > gfs2_init_inode_once, NULL); > if (!gfs2_inode_cachep) > goto fail; >