* [PATCH] GFS2: don't panic needlessly
@ 2006-10-27 23:03 Alexey Dobriyan
2006-10-30 9:47 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2006-10-27 23:03 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-fsdevel, Steven Whitehouse
First, SLAB_PANIC is unjustified. Second, all error propagating and backing out
is in place.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
fs/gfs2/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/fs/gfs2/main.c
+++ b/fs/gfs2/main.c
@@ -84,8 +84,8 @@ static int __init init_gfs2_fs(void)
gfs2_inode_cachep = kmem_cache_create("gfs2_inode",
sizeof(struct gfs2_inode),
- 0, (SLAB_RECLAIM_ACCOUNT|
- SLAB_PANIC|SLAB_MEM_SPREAD),
+ 0, SLAB_RECLAIM_ACCOUNT|
+ SLAB_MEM_SPREAD,
gfs2_init_inode_once, NULL);
if (!gfs2_inode_cachep)
goto fail;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] GFS2: don't panic needlessly
2006-10-27 23:03 [PATCH] GFS2: don't panic needlessly Alexey Dobriyan
@ 2006-10-30 9:47 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2006-10-30 9:47 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Andrew Morton, linux-fsdevel
Hi,
Thanks for the patch. Now applied to the GFS2 git tree,
Steve.
On Sat, 2006-10-28 at 03:03 +0400, Alexey Dobriyan wrote:
> First, SLAB_PANIC is unjustified. Second, all error propagating and backing out
> is in place.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> fs/gfs2/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/fs/gfs2/main.c
> +++ b/fs/gfs2/main.c
> @@ -84,8 +84,8 @@ static int __init init_gfs2_fs(void)
>
> gfs2_inode_cachep = kmem_cache_create("gfs2_inode",
> sizeof(struct gfs2_inode),
> - 0, (SLAB_RECLAIM_ACCOUNT|
> - SLAB_PANIC|SLAB_MEM_SPREAD),
> + 0, SLAB_RECLAIM_ACCOUNT|
> + SLAB_MEM_SPREAD,
> gfs2_init_inode_once, NULL);
> if (!gfs2_inode_cachep)
> goto fail;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-30 9:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-27 23:03 [PATCH] GFS2: don't panic needlessly Alexey Dobriyan
2006-10-30 9:47 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).