From: Dave Kleikamp <shaggy@austin.ibm.com>
To: guomingyang@nrchpc.ac.cn
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: I think I find a bug in ext3/dir.c
Date: Tue, 31 Oct 2006 09:23:45 -0600 [thread overview]
Message-ID: <1162308225.12059.4.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <200610311235.k9VCZZHv002689@nrchpc.ac.cn>
On Tue, 2006-10-31 at 20:23 +0800, guomingyang wrote:
> Hello everyone
>
> I think I find a bug in ext3_readdir
>
> if (err > 0) {
> page_cache_readahead(sb->s_bdev->bd_inode->i_mapping,
> &filp->f_ra,
> filp,
> map_bh.b_blocknr >>
> (PAGE_CACHE_SHIFT - inode->i_blkbits),
> 1);
> bh = ext3_bread(NULL, inode, blk, 0, &err);
> }
> map_bh.b_blocknr is the physical number of a block, but
> page_cache_readahead need a file-relative block number, am I right?
This is true, but the block-device inode, bd_inode, is trivially mapped
such that the physical block and the logical block are the same. So
it's not a bug. Directories don't have a logical mapping. They use the
block device's address space.
--
David Kleikamp
IBM Linux Technology Center
prev parent reply other threads:[~2006-10-31 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-31 12:23 I think I find a bug in ext3/dir.c guomingyang
2006-10-31 15:23 ` Dave Kleikamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162308225.12059.4.camel@kleikamp.austin.ibm.com \
--to=shaggy@austin.ibm.com \
--cc=guomingyang@nrchpc.ac.cn \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).