From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Kleikamp Subject: Re: [RFC/PATCH] - revert generic_fillattr stat->blksize to PAGE_CACHE_SIZE Date: Tue, 07 Nov 2006 09:34:12 -0600 Message-ID: <1162913653.8123.13.camel@kleikamp.austin.ibm.com> References: <454FAE0A.3070409@redhat.com> <1162852069.11030.70.camel@kleikamp.austin.ibm.com> <454FD2BE.2090302@us.ibm.com> <1162906845.8123.11.camel@kleikamp.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Eric Sandeen , Linux Kernel Mailing List , linux-fsdevel , Theodore Tso Return-path: Received: from e4.ny.us.ibm.com ([32.97.182.144]:42884 "EHLO e4.ny.us.ibm.com") by vger.kernel.org with ESMTP id S932088AbWKGPeW (ORCPT ); Tue, 7 Nov 2006 10:34:22 -0500 To: Steve French In-Reply-To: <1162906845.8123.11.camel@kleikamp.austin.ibm.com> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, 2006-11-07 at 07:40 -0600, Dave Kleikamp wrote: > It would probably be best to just set stat->blksize to the negotiated > buffer size. But be careful here. I don't know how applications/glibc may behave if stat->blksize is not a power of 2. -- David Kleikamp IBM Linux Technology Center