From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via idr) Date: Wed, 15 Nov 2006 15:36:29 -0500 Message-ID: <1163622989.3917.6.camel@tleilax.poochiereds.net> References: <1163535728.15846.21.camel@dantu.rdu.redhat.com> <20061115172719.GK19143@parisc-linux.org> <20061115175624.GE3399@wohnheim.fh-wedel.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Matthew Wilcox , linux-fsdevel@vger.kernel.org Return-path: Received: from mx1.redhat.com ([66.187.233.31]:16332 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1161413AbWKOUgb (ORCPT ); Wed, 15 Nov 2006 15:36:31 -0500 To: =?ISO-8859-1?Q?J=F6rn?= Engel In-Reply-To: <20061115175624.GE3399@wohnheim.fh-wedel.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 2006-11-15 at 18:56 +0100, J=C3=B6rn Engel wrote: > To keep the hashtable small, as per hch's request. Adding to the hashtable was my first suggestion (and actually it still seems reasonable to me), but according to hch, the reason most of these filesystems don't add their inodes to the hashtable is that they are generally pinned in memory. Adding them might slow down inode lookups for filesystems that don't pin their inodes. Still, even though they're pinned, we need to keep track of them someho= w to know that i_ino is unique. idr is one way, but there are certainly others. Another approach would be to add a entirely separate hashtable for these inodes, but I figured I'd try this way first. -- Jeff - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html