From: Jeff Layton <jlayton@redhat.com>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Matthew Wilcox <matthew@wil.cx>, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via pointer conversion)
Date: Fri, 17 Nov 2006 09:24:06 -0500 [thread overview]
Message-ID: <1163773446.13410.52.camel@dantu.rdu.redhat.com> (raw)
In-Reply-To: <20061117141445.GB9820@wohnheim.fh-wedel.de>
On Fri, 2006-11-17 at 15:14 +0100, Jörn Engel wrote:
> If you are talking about inode_init_once() here, I like the idea.
> i_generation must be initialized somehow, even a 4-byte information
> leak could be a problem. But the initialization should happen in the
> rare event of allocating a slab page, not when reusing a deleted
> inode.
>
> Jeff, why do you increment i_generation in new_inode instead of here?
I suppose we could do that...that might be better for stuff that calls
alloc_inode directly.
-- Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2006-11-17 14:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-17 13:43 [RFC][PATCH] ensure i_ino uniqueness in filesystems without permanent inode numbers (via pointer conversion) Jeff Layton
2006-11-17 13:50 ` Matthew Wilcox
2006-11-17 14:14 ` Jörn Engel
2006-11-17 14:24 ` Jeff Layton [this message]
2006-11-17 14:21 ` Jeff Layton
2006-11-17 16:31 ` Jeff Layton
2006-11-17 14:24 ` Matthew Wilcox
2006-11-17 14:48 ` Jeff Layton
2006-11-17 15:01 ` Dave Kleikamp
2006-11-17 15:06 ` Jeff Layton
2006-11-17 15:26 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163773446.13410.52.camel@dantu.rdu.redhat.com \
--to=jlayton@redhat.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).