From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steven Whitehouse <swhiteho@redhat.com>
Subject: Re: [PATCH] dlm & gfs2: use sysfs
Date: Fri, 26 Jan 2007 12:09:09 +0000
Message-ID: <1169813349.11001.127.camel@quoit.chygwyn.com>
References: <20070125184239.86d38bd9.rdunlap@xenotime.net>
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: Patrick Caulfield <pcaulfie@redhat.com>, cluster-devel@redhat.com,
	linux-fsdevel@vger.kernel.org, akpm <akpm@osdl.org>
To: Randy Dunlap <rdunlap@xenotime.net>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx1.redhat.com ([66.187.233.31]:42427 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S965527AbXAZMFB (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Fri, 26 Jan 2007 07:05:01 -0500
In-Reply-To: <20070125184239.86d38bd9.rdunlap@xenotime.net>
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

Hi,

Now in the GFS2 -nmw git tree. Thanks,

Steve.

On Thu, 2007-01-25 at 18:42 -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> With CONFIG_DLM=m, CONFIG_PROC_FS=n, and CONFIG_SYSFS=n, kernel build
> fails with:
> 
> WARNING: "kernel_subsys" [fs/gfs2/locking/dlm/lock_dlm.ko] undefined!
> WARNING: "kernel_subsys" [fs/dlm/dlm.ko] undefined!
> WARNING: "kernel_subsys" [fs/configfs/configfs.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> 
> Since fs/dlm/lockspace.c and fs/gfs2/locking/dlm/sysfs.c use
> kernel_subsys, they should either DEPEND on it or SELECT it.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  fs/dlm/Kconfig  |    1 +
>  fs/gfs2/Kconfig |    1 +
>  2 files changed, 2 insertions(+)
> 
> --- linux-2620-rc6.orig/fs/dlm/Kconfig
> +++ linux-2620-rc6/fs/dlm/Kconfig
> @@ -5,6 +5,7 @@ config DLM
>  	tristate "Distributed Lock Manager (DLM)"
>  	depends on IPV6 || IPV6=n
>  	select CONFIGFS_FS
> +	select SYSFS
>  	select IP_SCTP if DLM_SCTP
>  	help
>  	A general purpose distributed lock manager for kernel or userspace
> --- linux-2620-rc6.orig/fs/gfs2/Kconfig
> +++ linux-2620-rc6/fs/gfs2/Kconfig
> @@ -38,6 +38,7 @@ config GFS2_FS_LOCKING_DLM
>  	select IP_SCTP if DLM_SCTP
>  	select CONFIGFS_FS
>  	select DLM
> +	select SYSFS
>  	help
>  	Multiple node locking module for GFS2
>  
>