* [PATCH] dlm & gfs2: use sysfs
@ 2007-01-26 2:42 Randy Dunlap
2007-01-26 12:09 ` Steven Whitehouse
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2007-01-26 2:42 UTC (permalink / raw)
To: cluster-devel, linux-fsdevel; +Cc: swhiteho, akpm
From: Randy Dunlap <randy.dunlap@oracle.com>
With CONFIG_DLM=m, CONFIG_PROC_FS=n, and CONFIG_SYSFS=n, kernel build
fails with:
WARNING: "kernel_subsys" [fs/gfs2/locking/dlm/lock_dlm.ko] undefined!
WARNING: "kernel_subsys" [fs/dlm/dlm.ko] undefined!
WARNING: "kernel_subsys" [fs/configfs/configfs.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2
Since fs/dlm/lockspace.c and fs/gfs2/locking/dlm/sysfs.c use
kernel_subsys, they should either DEPEND on it or SELECT it.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
fs/dlm/Kconfig | 1 +
fs/gfs2/Kconfig | 1 +
2 files changed, 2 insertions(+)
--- linux-2620-rc6.orig/fs/dlm/Kconfig
+++ linux-2620-rc6/fs/dlm/Kconfig
@@ -5,6 +5,7 @@ config DLM
tristate "Distributed Lock Manager (DLM)"
depends on IPV6 || IPV6=n
select CONFIGFS_FS
+ select SYSFS
select IP_SCTP if DLM_SCTP
help
A general purpose distributed lock manager for kernel or userspace
--- linux-2620-rc6.orig/fs/gfs2/Kconfig
+++ linux-2620-rc6/fs/gfs2/Kconfig
@@ -38,6 +38,7 @@ config GFS2_FS_LOCKING_DLM
select IP_SCTP if DLM_SCTP
select CONFIGFS_FS
select DLM
+ select SYSFS
help
Multiple node locking module for GFS2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] dlm & gfs2: use sysfs
2007-01-26 2:42 [PATCH] dlm & gfs2: use sysfs Randy Dunlap
@ 2007-01-26 12:09 ` Steven Whitehouse
0 siblings, 0 replies; 2+ messages in thread
From: Steven Whitehouse @ 2007-01-26 12:09 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Patrick Caulfield, cluster-devel, linux-fsdevel, akpm
Hi,
Now in the GFS2 -nmw git tree. Thanks,
Steve.
On Thu, 2007-01-25 at 18:42 -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> With CONFIG_DLM=m, CONFIG_PROC_FS=n, and CONFIG_SYSFS=n, kernel build
> fails with:
>
> WARNING: "kernel_subsys" [fs/gfs2/locking/dlm/lock_dlm.ko] undefined!
> WARNING: "kernel_subsys" [fs/dlm/dlm.ko] undefined!
> WARNING: "kernel_subsys" [fs/configfs/configfs.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
>
> Since fs/dlm/lockspace.c and fs/gfs2/locking/dlm/sysfs.c use
> kernel_subsys, they should either DEPEND on it or SELECT it.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> fs/dlm/Kconfig | 1 +
> fs/gfs2/Kconfig | 1 +
> 2 files changed, 2 insertions(+)
>
> --- linux-2620-rc6.orig/fs/dlm/Kconfig
> +++ linux-2620-rc6/fs/dlm/Kconfig
> @@ -5,6 +5,7 @@ config DLM
> tristate "Distributed Lock Manager (DLM)"
> depends on IPV6 || IPV6=n
> select CONFIGFS_FS
> + select SYSFS
> select IP_SCTP if DLM_SCTP
> help
> A general purpose distributed lock manager for kernel or userspace
> --- linux-2620-rc6.orig/fs/gfs2/Kconfig
> +++ linux-2620-rc6/fs/gfs2/Kconfig
> @@ -38,6 +38,7 @@ config GFS2_FS_LOCKING_DLM
> select IP_SCTP if DLM_SCTP
> select CONFIGFS_FS
> select DLM
> + select SYSFS
> help
> Multiple node locking module for GFS2
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-26 12:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-26 2:42 [PATCH] dlm & gfs2: use sysfs Randy Dunlap
2007-01-26 12:09 ` Steven Whitehouse
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).