linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: sfaibish <sfaibish@emc.com>
Cc: Theodore Tso <tytso@mit.edu>,
	Valerie Henson <val_henson@linux.intel.com>,
	linux-fsdevel@vger.kernel.org, Can Sar <csar@stanford.edu>,
	Junfeng Yang <junfeng@gmail.com>,
	Dawson Engler <engler@csl.stanford.edu>
Subject: Re: Fix(es) for ext2 fsync bug
Date: Thu, 15 Feb 2007 10:39:02 -0600	[thread overview]
Message-ID: <1171557542.14606.7.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <op.tnsr13qnunckof@usensfaibisl2e.eng.emc.com>

On Thu, 2007-02-15 at 10:59 -0500, sfaibish wrote:
> On Thu, 15 Feb 2007 10:09:22 -0500, Dave Kleikamp  
> <shaggy@linux.vnet.ibm.com> wrote:
> 
> > On Thu, 2007-02-15 at 09:20 -0500, Theodore Tso wrote:
> >
> >> Another very heavyweight approach would be to simply force a full sync
> >> of the filesystem whenever fysnc() is called.  Not pretty, and without
> >> the proper write ordering, the race is still potentially there.
> >
> > I don't think this race is an issue, in that it would require the crash
> > to happen before the fsync completed, so there would be no expectation
> > that the data is safe.  It's a moot point, since I don't think this is
> > an acceptable solution anyway.
> >
> >> I'd say that the best way to handle this is in fsck, but quite frankly
> >> it's relatively low priority "bug" to handle, since a much simpler
> >> workaround is to tell people to use ext3 instead.
> >
> > Right.  Who's still using ext2?
> It was my understanding from the persentation of Dawson that ext3 and jfs  
> have
> same problem.

Hmm.  If jfs has the problem, it is a bug.  jfs is designed to handle
this correctly.  I'm pretty sure I've fixed at least one bug that
eXplode has uncovered in the past.  I'm not sure what was mentioned in
the presentation though.  I'd like any information about current
problems in jfs.

> It is not an ext2 only problem. Also whatever solution we  
> adopt
> we need to be sure that we test it using the eXplode methodology.
> 
> /Sorin
-- 
David Kleikamp
IBM Linux Technology Center


  reply	other threads:[~2007-02-15 16:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-14 19:54 Fix(es) for ext2 fsync bug Valerie Henson
2007-02-14 20:31 ` David Chinner
2007-02-14 21:26   ` Dave Kleikamp
2007-02-14 23:32     ` David Chinner
2007-02-14 21:08 ` sfaibish
2007-02-15 14:20 ` Theodore Tso
2007-02-15 15:09   ` Dave Kleikamp
2007-02-15 15:59     ` sfaibish
2007-02-15 16:39       ` Dave Kleikamp [this message]
2007-02-15 17:15         ` Theodore Tso
2007-02-15 17:52           ` sfaibish
     [not found]         ` <21e789ec0702151111v4cb2aa8dqa168c886cb909c9@mail.gmail.com>
2007-02-15 19:26           ` Dave Kleikamp
2007-02-15 18:54       ` Dawson Engler
     [not found]         ` <21e789ec0702151118x1c6af801gd34981d72db0f5b2@mail.gmail.com>
     [not found]           ` <21e789ec0702151128x744f61e5lb24d2da972af185a@mail.gmail.com>
2007-02-16  1:18             ` Theodore Tso
2007-02-20 21:13     ` Valerie Henson
     [not found]       ` <21e789ec0702201330x1c2706b7kcd055b97cb37e0e@mail.gmail.com>
2007-02-20 21:39         ` Valerie Henson
2007-02-20 21:47           ` Dawson Engler
2007-02-20 22:25           ` Dave Kleikamp
2007-02-20 21:30   ` Valerie Henson
2007-02-20 22:12     ` Erez Zadok

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1171557542.14606.7.camel@kleikamp.austin.ibm.com \
    --to=shaggy@linux.vnet.ibm.com \
    --cc=csar@stanford.edu \
    --cc=engler@csl.stanford.edu \
    --cc=junfeng@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sfaibish@emc.com \
    --cc=tytso@mit.edu \
    --cc=val_henson@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).