From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Kleikamp Subject: Re: Fix(es) for ext2 fsync bug Date: Thu, 15 Feb 2007 10:39:02 -0600 Message-ID: <1171557542.14606.7.camel@kleikamp.austin.ibm.com> References: <20070214195453.GB7521@nifty> <20070215142020.GA9930@thunk.org> <1171552162.21710.9.camel@kleikamp.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Theodore Tso , Valerie Henson , linux-fsdevel@vger.kernel.org, Can Sar , Junfeng Yang , Dawson Engler To: sfaibish Return-path: Received: from e4.ny.us.ibm.com ([32.97.182.144]:43891 "EHLO e4.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966099AbXBOQjH (ORCPT ); Thu, 15 Feb 2007 11:39:07 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e4.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id l1FGd4Bm032581 for ; Thu, 15 Feb 2007 11:39:04 -0500 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v8.2) with ESMTP id l1FGd4F1274564 for ; Thu, 15 Feb 2007 11:39:04 -0500 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l1FGd3Jj002182 for ; Thu, 15 Feb 2007 11:39:04 -0500 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 2007-02-15 at 10:59 -0500, sfaibish wrote: > On Thu, 15 Feb 2007 10:09:22 -0500, Dave Kleikamp > wrote: > > > On Thu, 2007-02-15 at 09:20 -0500, Theodore Tso wrote: > > > >> Another very heavyweight approach would be to simply force a full sync > >> of the filesystem whenever fysnc() is called. Not pretty, and without > >> the proper write ordering, the race is still potentially there. > > > > I don't think this race is an issue, in that it would require the crash > > to happen before the fsync completed, so there would be no expectation > > that the data is safe. It's a moot point, since I don't think this is > > an acceptable solution anyway. > > > >> I'd say that the best way to handle this is in fsck, but quite frankly > >> it's relatively low priority "bug" to handle, since a much simpler > >> workaround is to tell people to use ext3 instead. > > > > Right. Who's still using ext2? > It was my understanding from the persentation of Dawson that ext3 and jfs > have > same problem. Hmm. If jfs has the problem, it is a bug. jfs is designed to handle this correctly. I'm pretty sure I've fixed at least one bug that eXplode has uncovered in the past. I'm not sure what was mentioned in the presentation though. I'd like any information about current problems in jfs. > It is not an ext2 only problem. Also whatever solution we > adopt > we need to be sure that we test it using the eXplode methodology. > > /Sorin -- David Kleikamp IBM Linux Technology Center