From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Josef 'Jeff' Sipek" Subject: [PATCH 06/13] fs/unionfs/: Remove alloc_filldir_node Date: Sun, 4 Mar 2007 21:16:50 -0500 Message-ID: <11730610183118-git-send-email-jsipek@cs.sunysb.edu> References: <11730610174005-git-send-email-jsipek@cs.sunysb.edu> Cc: "Josef 'Jeff' Sipek" To: linux-fsdevel@vger.kernel.org Return-path: Received: from filer.fsl.cs.sunysb.edu ([130.245.126.2]:39136 "EHLO filer.fsl.cs.sunysb.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbXCECRF (ORCPT ); Sun, 4 Mar 2007 21:17:05 -0500 In-Reply-To: <11730610174005-git-send-email-jsipek@cs.sunysb.edu> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org alloc_filldir_node was used only once. Additionally, all the arguments passed to it were ignored wasting stack space for no reason whatsoever. Signed-off-by: Josef 'Jeff' Sipek --- fs/unionfs/rdstate.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/rdstate.c b/fs/unionfs/rdstate.c index e240285..b67a86a 100644 --- a/fs/unionfs/rdstate.c +++ b/fs/unionfs/rdstate.c @@ -225,12 +225,6 @@ struct filldir_node *find_filldir_node(struct unionfs_dir_state *rdstate, return cursor; } -static struct filldir_node *alloc_filldir_node(const char *name, int namelen, - unsigned int hash, int bindex) -{ - return kmem_cache_alloc(unionfs_filldir_cachep, GFP_KERNEL); -} - int add_filldir_node(struct unionfs_dir_state *rdstate, const char *name, int namelen, int bindex, int whiteout) { @@ -246,7 +240,7 @@ int add_filldir_node(struct unionfs_dir_state *rdstate, const char *name, index = hash % rdstate->size; head = &(rdstate->list[index]); - new = alloc_filldir_node(name, namelen, hash, bindex); + new = kmem_cache_alloc(unionfs_filldir_cachep, GFP_KERNEL); if (!new) { err = -ENOMEM; goto out; -- 1.5.0.2.260.g2eb065